Skip to content

Upload verified Binance fee snapshots to OSS - #791

Merged
proerror77 merged 17 commits into
mainfrom
codex/binance-fee-oss-transport
Aug 9, 2026
Merged

proerror77 merged 17 commits into
mainfrom
codex/binance-fee-oss-transport

Conversation

@proerror77

@proerror77 proerror77 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Change contract

Upload authenticated Binance fee snapshot data/manifest/_SUCCESS triplets to OSS, verify typed remote readback, and remove the local source only after that readback succeeds.

Issue relationship

Closes #790

Out of scope

Credential provisioning, service/timer deployment, Live trading, and PM Reference changes.

Dependencies and merge order

Stacked on PR #789; merge #789 first, then retarget this PR to main.

Focused validation

  • Linux target collector Clippy with warnings denied passes.
  • Linux target test binaries compile; CI runs the two fake-OSS behavioral tests.
  • Corrupt remote _SUCCESS retains all three local source files.
  • Verified data/manifest/_SUCCESS readback removes the local batch.
  • Native macOS test execution is unavailable because existing polymarket_upload.rs uses Linux-only libc::RUSAGE_THREAD.

Rollout and rollback

No runtime mutation in this PR. Roll back the image/version; local source remains unless the remote triplet has passed typed readback.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5388dc40-e594-4178-a83a-b24b9706580e

📥 Commits

Reviewing files that changed from the base of the PR and between 4e8358f and f924e07.

📒 Files selected for processing (8)
  • .github/workflows/acr-publish.yml
  • agent-worktree.yml
  • rust_hft/deployment/docker/Dockerfile.binance-lob-archiver
  • rust_hft/tools/collector/Cargo.toml
  • rust_hft/tools/collector/src/bin/binance-fee-snapshot-upload.rs
  • rust_hft/tools/collector/src/binance_fee_upload.rs
  • rust_hft/tools/collector/src/binance_usdm_reference_upload.rs
  • rust_hft/tools/collector/src/lib.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77

Copy link
Copy Markdown
Owner Author

@codex review exact head 59bf181: verify typed OSS triplet readback, fail-closed local retention, authenticated partition binding, and status semantics.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59bf18107f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust_hft/tools/collector/src/binance_fee_upload.rs
Comment thread rust_hft/tools/collector/src/binance_fee_upload.rs Outdated
Comment thread rust_hft/tools/collector/src/binance_fee_upload.rs
@proerror77

Copy link
Copy Markdown
Owner Author

@codex review exact head 7c73f1c: verify received-at partition binding, persisted discovery failures, exact triplet digest receipts, and fail-closed local retention.

@proerror77

Copy link
Copy Markdown
Owner Author

@codex review exact head 97a35e4: final transport head; prior fixes unchanged, trivial CLI parsing test removed to keep the rollback unit below the repository scope limit.

Base automatically changed from codex/fee-account-binding to main August 9, 2026 22:43
…-transport

# Conflicts:
#	agent-worktree.yml
@proerror77
proerror77 enabled auto-merge (squash) August 9, 2026 22:45
@proerror77

Copy link
Copy Markdown
Owner Author

@codex review exact head f924e07 after retarget to main: verify final fee OSS transport and exact merged account-binding dependency.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: f924e073ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@proerror77
proerror77 merged commit f9cd212 into main Aug 9, 2026
51 of 53 checks passed
@proerror77
proerror77 deleted the codex/binance-fee-oss-transport branch August 9, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship Binance fee snapshot OSS artifact transport

1 participant