ci: preserve Rust cache restore prefixes - #806
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change removes redundant ChangesRust cache stabilization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5ebcda4 to
7cbb344
Compare
Change contract
Remove the duplicate
Cargo.lockhash from the three Rust cache user keys used by Research image binaries, manual research-runner rebuilds, and Rust Workspace.Swatinem/rust-cache@v2keeps its own Rust environment and lockfile hashes, so this restores the stable fallback prefix across lockfile changes without weakening full-key invalidation.Issue relationship
None
Out of scope
save-ifbehaviorDependencies and merge order
None. Base:
origin/mainat2fb07d94c245f71ac6508fe12ebbe416118a3eba.Focused validation
.github/scripts/test-acr-publish-workflow.shpasses after the change.actionlint v1.7.8passes forploy-ci.yml,acr-publish.yml, andci.yml.git diff --checkpasses.agent-worktree-preflight.shcurrently exits 141 at its pre-existinggit worktree list --porcelain | awk ... exitpipeline underpipefail; running the same check without the early pipe close returnsverdict=okfor this worktree and ownership record.add-rust-environment-hash-keyremains at the action's documented defaulttrue. It is not written explicitly because this repository's pinned actionlint metadata rejects that otherwise valid action input.Rollout and rollback
No production runtime mutation. After merge, observe the next lockfile-changing main run: the cache may restore by the stable Rust-environment prefix while still saving under the action-computed full lockfile key. Rollback is a revert of this PR.
Scope exception
None.
Summary by CodeRabbit
Bug Fixes
Tests