fix(deploy): accept collocated reference uploader upgrades - #808
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
baa9ec4 to
310f90a
Compare
310f90a to
3c6624e
Compare
Change contract
Allow a Binance USD-M Reference release produced by this cutover to pass the next upgrade preflight. The old uploader must be collocated with the previous collector release, and its release sidecar plus actual binary SHA-256 must match before any runtime transition starts. A long-lived baseline may retain planned
RuntimeMaxSecrestarts; the preflight still requires the exact running binary, while freshly started candidate and rollback processes must keepNRestarts=0. The receipt keeps the previous collector release SHA and actual uploader SHA; the obsolete standalone uploader-release field was removed after a full-repo search found no consumer.Issue relationship
None
Out of scope
Dependencies and merge order
None
Focused validation
deployment/aliyun/test-binance-usdm-reference-release-contract.shdeployment/aliyun/test-binance-usdm-reference-shadow-gate.shdeployment/aliyun/test-binance-usdm-reference-host-gate.shbash -n deployment/aliyun/binance-usdm-reference-cutover.sh deployment/aliyun/test-binance-usdm-reference-host-gate.shshellcheck deployment/aliyun/binance-usdm-reference-cutover.sh deployment/aliyun/test-binance-usdm-reference-host-gate.shgit diff --checkprevious_uploader_release_sha256is absent andprevious_uploader_sha256remains bound to the actual old uploader bytes.The repository preflight script itself exits 141 with the current 190+ worktrees because its
git worktree list | awk ... exitpipeline tripspipefail; the same checks with the consumer draining the full worktree list returnedverdict=ok. This PR does not alter that unrelated script.Rollout and rollback
Code-only change; production was not touched. After merge, publish a new exact-head artifact before opening the separate #803 runtime rollout. Roll back this code by reverting the PR before any candidate staging.
Scope exception
None