fix(polymarket): raise reference soft memory watermark - #85
Conversation
Constraint: Formal production gates on July 17, 2026 hit memory.events high at 586.1M and 605.8M while MemoryMax stayed untouched Rejected: Keep 576M and retry gate | reproduced fail-closed twice with current host workload Directive: Keep MemoryMax at 768M unless a future formal gate proves the hard limit itself is too low Confidence: high Scope-risk: narrow Tested: CARGO_BUILD_JOBS=1 deployment/aliyun/test-polymarket-raw-ops-control-plane.sh
|
Warning Review limit reached
Next review available in: 14 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b744f145bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| UMask=0027 | ||
| CPUQuota=80% | ||
| MemoryHigh=576M | ||
| MemoryHigh=672M |
There was a problem hiding this comment.
With this unit now setting MemoryHigh=672M, the Rust test systemd_reference_resource_envelope_is_pinned still includes these service files and asserts high == 576 in rust_hft/tools/collector/src/polymarket_raw.rs:2323-2328. Any cargo test -p hft-collector ... run for the collector will fail as soon as it parses this changed line, so the documented control-plane validation cannot pass until the pinned test expectation is updated with the new envelope.
Useful? React with 👍 / 👎.
Change contract
Raise the Polymarket Rust reference shadow and production service soft memory watermark from 576M to 672M while keeping the 768M hard cap unchanged, so the formal gate stays fail-closed on real OOM/max events instead of failing on the newly observed startup working set.
Out of scope
MemoryMax=768MDependency or merge order
mainFocused validation
CARGO_BUILD_JOBS=1 cargo test -p hft-collector systemd_reference_resource_envelope_is_pinned --lockeddeployment/aliyun/test-polymarket-raw-ops-control-plane.shMemoryMax=768Mor recording an OOM.Rollout/rollback impact
PASSED.sha256evidence.