Skip to content

fix(deployment): allow bounded shadow bootstrap settle - #852

Merged
proerror77 merged 1 commit into
mainfrom
codex/health-settle-900-846
Aug 12, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/health-settle-900-846

Conversation

@proerror77

@proerror77 proerror77 commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Change

Increase the installed Rust LOB shadow Harness settle budget from 300s to 900s. The same bounded value continues to govern initial/bootstrap settle, transport-recovery settle extension, and the recovery safety ceiling; SOAK_SECONDS remains the post-full-coverage observation duration. The existing total feed deadline remains SOAK_SECONDS + HEALTH_SETTLE_SECONDS + 300, so the run remains bounded.

The contract test now locks the 900s default, bounded recovery checks, total feed deadline, and ordering that starts observation timing only after both markets pass full-health settle.

Issue relationship

Refs #846

Validation

  • Red before fix: bash deployment/aliyun/test-rust-lob-shadow-soak.sh exited 1 at the new 900s contract assertion while the Harness still declared 300s.
  • Green after fix: bash deployment/aliyun/test-rust-lob-shadow-soak.sh — Rust LOB shadow-soak contract passed.
  • bash -n deployment/aliyun/host-rust-lob-shadow-soak.sh deployment/aliyun/test-rust-lob-shadow-soak.sh
  • shellcheck deployment/aliyun/host-rust-lob-shadow-soak.sh deployment/aliyun/test-rust-lob-shadow-soak.sh
  • git diff --check
  • Harness self-test: shadow-soak self-test: ok

Runtime impact and rollback

No runtime command, installation, deployment, Gate, cutover, or Live action was performed for this change. The previous 300s default remains the one-line rollback. The failed #846 runtime attempt remains STOP with its evidence and was not retried.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: de32af31-09b9-482a-931c-dff17c678dfc

📥 Commits

Reviewing files that changed from the base of the PR and between 0c635f6 and b0d88f9.

📒 Files selected for processing (2)
  • deployment/aliyun/host-rust-lob-shadow-soak.sh
  • deployment/aliyun/test-rust-lob-shadow-soak.sh

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 934894b0-2993-4bfe-9c92-3f982ff8a308

📥 Commits

Reviewing files that changed from the base of the PR and between a0a2726 and 0c635f6.

📒 Files selected for processing (2)
  • deployment/aliyun/host-rust-lob-shadow-soak.sh
  • deployment/aliyun/test-rust-lob-shadow-soak.sh

📝 Walkthrough

Walkthrough

The Rust LOB shadow-soak script increases health settling from 300 to 900 seconds. Its contract test validates derived durations, deadlines, and the ordering of readiness and observation setup.

Changes

Rust LOB shadow-soak timing

Layer / File(s) Summary
Extend health-settle timing
deployment/aliyun/host-rust-lob-shadow-soak.sh
Sets HEALTH_SETTLE_SECONDS to 900 seconds.
Validate timing contracts and ordering
deployment/aliyun/test-rust-lob-shadow-soak.sh
Checks derived duration and deadline calculations. It also verifies the order of readiness, observation start, and soak deadline assignment.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the bounded shadow bootstrap settle change.
Description check ✅ Passed The description includes all required sections and provides clear change, issue, validation, runtime impact, and rollback details.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/health-settle-900-846

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c635f66af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread deployment/aliyun/host-rust-lob-shadow-soak.sh Outdated
@proerror77
proerror77 force-pushed the codex/health-settle-900-846 branch from 0c635f6 to b0d88f9 Compare August 12, 2026 10:17
@proerror77
proerror77 merged commit 1e526bf into main Aug 12, 2026
44 checks passed
@proerror77
proerror77 deleted the codex/health-settle-900-846 branch August 12, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant