fix(deployment): allow bounded shadow bootstrap settle - #852
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Rust LOB shadow-soak script increases health settling from 300 to 900 seconds. Its contract test validates derived durations, deadlines, and the ordering of readiness and observation setup. ChangesRust LOB shadow-soak timing
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c635f66af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0c635f6 to
b0d88f9
Compare
Change
Increase the installed Rust LOB shadow Harness settle budget from 300s to 900s. The same bounded value continues to govern initial/bootstrap settle, transport-recovery settle extension, and the recovery safety ceiling;
SOAK_SECONDSremains the post-full-coverage observation duration. The existing total feed deadline remainsSOAK_SECONDS + HEALTH_SETTLE_SECONDS + 300, so the run remains bounded.The contract test now locks the 900s default, bounded recovery checks, total feed deadline, and ordering that starts observation timing only after both markets pass full-health settle.
Issue relationship
Refs #846
Validation
bash deployment/aliyun/test-rust-lob-shadow-soak.shexited 1 at the new 900s contract assertion while the Harness still declared 300s.bash deployment/aliyun/test-rust-lob-shadow-soak.sh— Rust LOB shadow-soak contract passed.bash -n deployment/aliyun/host-rust-lob-shadow-soak.sh deployment/aliyun/test-rust-lob-shadow-soak.shshellcheck deployment/aliyun/host-rust-lob-shadow-soak.sh deployment/aliyun/test-rust-lob-shadow-soak.shgit diff --checkshadow-soak self-test: okRuntime impact and rollback
No runtime command, installation, deployment, Gate, cutover, or Live action was performed for this change. The previous 300s default remains the one-line rollback. The failed #846 runtime attempt remains STOP with its evidence and was not retried.