fix(polymarket): retain fresh pre-open references - #99
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChainlink reference prices recorded up to 30 seconds before an event are now eligible for normalization. The manifest recording semantics and tests document and validate the half-open ChangesChainlink reference window
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Change contract
Treat typed BTC/SOL Chainlink references whose source timestamp is in
[event_start - 30 seconds, event_end)as belonging to the event while preserving their original arrival clocks, and disclose that exact half-open window in the immutable evidence manifest.Out of scope
Dependency / merge order
Depends on the immutable evidence manifest publisher from #98, which is merged into
main. No outstanding stacked dependency remains.Focused validation
cargo test --locked -p hft-collector polymarket_research_normalize::tests -- --nocapture(9 passed)cargo test --locked -p hft-collector(180 passed,2 ignored)cargo clippy --locked -p hft-collector --all-targets -- -D warningscargo fmt --package hft-collector -- --checkgit diff --checkmarket_rows, lateavailable_atwithout backdating, completeness with only the pre-open reference, and exact manifest disclosure.Rollout / rollback impact
This changes only normalized research-evidence membership and its manifest disclosure. It does not change collection or execution. Rollback removes the 30-second pre-open membership and restores the previous event-only reference window; previously published content-addressed evidence remains immutable.
Scope evidence
Summary by CodeRabbit