Uh oh!
There was an error while loading. Please reload this page.
Add Unsupported error for cases when storcli returns Un-supported. - #99
Closed
smoser wants to merge 1 commit into
Closed
Add Unsupported error for cases when storcli returns Un-supported.#99smoser wants to merge 1 commit into
smoser wants to merge 1 commit into
Conversation
smoserforce-pushed
the
fix/unsupported-cards
branch
from
March 31, 2021 20:56
fa7febf to
c334fe0CompareCodecov Report
@@ Coverage Diff @@## master #99 +/- ##
==========================================
+ Coverage 64.30% 64.54% +0.23%
==========================================
Files 16 16 Lines 1706 1709 +3 ==========================================
+ Hits 1097 1103 +6 + Misses 441 439 -2 + Partials 168 167 -1
Continue to review full report at Codecov.
|
raharper
left a comment
Collaborator
There was a problem hiding this comment.
I saw two places with extra 'd' in Unsupported, not sure if that was intentional. Otherwise looks fine.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The SAS3508 returns Un-supported when you ask it: storcli /c0/dall show all storcli /c0/vall show all I'm not sure how we should query this card, but for the time being just add a new error type of Unsupported.
smoserforce-pushed
the
fix/unsupported-cards
branch
from
April 1, 2021 01:22
c334fe0 to
a1633e0Comparesmoser
commented
Apr 1, 2021
CollaboratorAuthor
@raharper adjusted, thank you for careful review. |
smoser pushed a commit
to smoser/disko
that referenced
this pull request
Apr 1, 2021
For megaraid cards that do not support raid (true story), the /c0/dall request will return Un-supported. But you can still get the same information from the 'storcli /c0 show'. Fixesproject-machine#99.
smoser
commented
Apr 2, 2021
CollaboratorAuthor
Closing this in favor of #100. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SAS3508 returns Un-supported when you ask it:
I'm not sure how we should query this card, but for the time being
just add a new error type of Unsupported.