Uh oh!
There was an error while loading. Please reload this page.
add openshift labels for app deployment - #69
Conversation
aweiteka
commented
Apr 21, 2016
aweiteka
commented
Apr 21, 2016
@bparees I didn't see docs on mid hooks. Do I have the right hook type in mind? |
| | io.openshift.tags | no | tags used by searching engine, e.g. `"builder,php,php56,rh-php56"` | | ||
| | io.openshift.env-KEY | no | Required environment variable. Creates parameter named "KEY". If no value is provided user input required. | | ||
| | io.openshift.podhook.pre | no | Pre exec pod-based lifecycle hook command. See [documentation](https://docs.openshift.org/latest/dev_guide/deployments.html#pod-based-lifecycle-hook) | | ||
| | io.openshift.podhook.post | no | Post exec pod-based lifecycle hook command. See [documentation](https://docs.openshift.org/latest/dev_guide/deployments.html#pod-based-lifecycle-hook) | |
There was a problem hiding this comment.
it's a deployment hook, not a pod hook. the "pod-based" part refers to the fact that the logic is executed in a pod.
bparees
commented
Apr 21, 2016
@aweiteka might be missing doc. @ironcladlou do we not have doc for mid-hooks? |
bparees
commented
Apr 21, 2016
we probably need to see an example of how those labels will actually look with values. Presumably it's going to be a giant blob of json (that defines a hook), which seems unfriendly but is going to be the most flexible option.... |
ironcladlou
commented
Apr 28, 2016
There's a documentation gap around mid hooks. They're supported only by the |
aweiteka
commented
Apr 28, 2016
Mid hooks docs issue pointing to implementation PR: openshift/openshift-docs#1779 |
aweiteka
commented
Apr 28, 2016
We could add |
ceeb63f to
84a6933Compareaweiteka
commented
May 2, 2016
@brianwcook updated. |
| |Name | Description | | ||
| |-------------|-------------| | ||
| | config.env.KEY | Default value. Use empty string "" if no default.| |
There was a problem hiding this comment.
i think we were doing to skip having a "default" value label and just try to pick up the default from any ENV statement in the dockerfile. But after we got off the phone, i had second thoughts and i think we still want to have an (optional) default label, but the name should be:config.env.KEY.default
we were also going to add another optional label:config.env.KEY.displayName
which is a value used to label the input field for the value in UIs. (if not provided, the label for the field will just KEY)
No description provided.