review: whole-repo round on the describe, workload and network commands and docs by CMGS · Pull Request #130 · projecteru2/cli

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS · 2026-09-03T00:13:51Z

Whole-repo review round on the current master: the judgment, style and docs ledgers of the 2026-09-03 audit, applied.

Every describe table renders through renderTable, which now takes row groups; the four open-coded table frames are gone (the image table keeps its own column config).
One ReadSpecURI reads a spec from a URL or a file for both image build and the workload commands.
The deploy and replace commands build their common DeployOptions once; the cpumem params of deploy and realloc come from one helper.
Network connect and disconnect validate their target through one helper; dissociate dedupes ids with slices; GetNetworks splits with strings.Cut (a value carrying a second = keeps its pinned meaning); describeChOr decides the format once; listChan is inlined; ToChan lives with the tests that use it.

Docs: exit codes (255 after argument parsing, 1 for usage errors, 3 for unknown commands, image build passes core's code through), --output exceptions, --version fields, global option placement, pod capacity required flags, the lambda command-line rule and defaults, the --extra-resources example and note, the short flag aliases the tables omitted, the unset template variable rendering <no value>, and the README output claim.

Evidence: build, vet, full tests, lint and fmt-check on linux and darwin, asl on both, all green; exit codes and --help defaults measured on a binary built from this branch. Net production Go −99 lines, tests +11 (the moved helper), comments +0/−0.

renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

The helper had one caller and existed only to wrap a two-line stream open.

It has no production caller.

The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

connect and disconnect repeated the same client, ids and network checks.

deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

deploy and replace repeated the same eighteen fields; replace is now the base options unchanged, deploy overlays the five it adds. Reading the --file flags moves ahead of parsing memory and storage, so a command with two bad inputs can now report the file error first.

Measured on a built binary: an action error exits 255, a usage error 1 and an unknown command 3, image build carries core's own code, --version prints OS/Arch, and lambda shows --memory-request empty and --deploy-strategy AUTO. The command tables now carry the short aliases --help advertises, the required flags on pod capacity, the full --file form and the extra-resources plugin example the flag itself uses.

CMGS added 11 commits September 3, 2026 08:11

review: render every describe table through renderTable
0f93ffe
renderTable now takes row groups, so node and workload tables no longer build their own table writer. Golden-output tests are unchanged.

review: read a spec uri through one helper
ecb7cea
image build and workload loadSpecs both branched on the http prefix themselves; utils.ReadSpecURI now carries that branch.

review: dedupe dissociate ids with slices
0831abd
The hand-rolled seen-set becomes sorted plus compacted; the ids only reach the rpc as a set.

review: render collected channel items without a no-op fallback
579a05d
describeChOr decided the format twice, the second time through describeOr with a fallback that could never run.

review: inline listChan into the pod nodes run
4f8e5e7
The helper had one caller and existed only to wrap a two-line stream open.

review: move ToChan into the describe tests
183d67d
It has no production caller.

review: split a network value with strings.Cut
b0c52a7
The extra check on the remainder keeps the tested behaviour that a value with two separators stays a bare network name.

review: validate the network command target once
2e6069c
connect and disconnect repeated the same client, ids and network checks.

review: build the cpumem params in one place
2b8cec2
deploy and realloc spelled out the same four-key RawParams before adding their own cpu-bind keys.

CMGS merged commit bda7f7c into masterSep 3, 2026
5 checks passed

CMGS deleted the rv-cli branch September 3, 2026 00:26