Uh oh!
There was an error while loading. Please reload this page.
(fluent.syntax) Don't drop to newline when serializing patterns starting with special chars - #156
Merged
Conversation
…ing with special chars
stasmforce-pushed
the
fix-special-chars-infront
branch
from
August 27, 2020 12:12
ec9340b to
2774242ComparePike
approved these changes
Aug 27, 2020
Pike
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the port.
Things I checked for in differences to JS: elements[0]´ would behave different in js and python, but is guarded by any([])` being false.
Different number of files is due to the abscense of a runtime parser in python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of projectfluent/fluent.js#513.