Uh oh!
There was an error while loading. Please reload this page.
[Refactor] 공통 BottomSheet 컴포넌트 + Selection 4곳 교체 #499 - #500
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#499
📝작업 내용
공통 BottomSheet 컴포넌트를 추가하고, SelectionBottomSheetDialog 사용처 4곳을 교체했습니다.
공통 BottomSheet 컴포넌트
UndabangBottomSheet(BottomSheetDialogFragment, ComposeView + applyAppTheme)SelectionBottomSheetContentComposable, 기존 bottom_sheet_dialog_select 디자인 이식showSelection(...)팩토리SelectionBottomSheetDialog 호출부 교체
ExerciseFormFragment- 운동 종류, 운동 위치 (2곳)FeedFormFragment- 다방 선택FeedListFragment- 카테고리 선택정리
SelectionBottomSheetDialog,SelectionRVAdapter삭제스크린샷 (선택)
💬리뷰 요구사항(선택)