Skip to content

feat: adds createdTimestamp to counters exposed via prometheus protouf protocol - #1532

Merged
zeitlinger merged 1 commit into
prometheus:mainfrom
cmaune:add-created-timestamp
Sep 3, 2025
Merged

feat: adds createdTimestamp to counters exposed via prometheus protouf protocol#1532
zeitlinger merged 1 commit into
prometheus:mainfrom
cmaune:add-created-timestamp

Conversation

@cmaune

Copy link
Copy Markdown
Contributor

@cmaune
cmauneforce-pushed the add-created-timestamp branch from 000f9f8 to 139b160CompareAugust 22, 2025 16:20
@zeitlinger

Copy link
Copy Markdown
Member

@cmaune there are test failures

@cmaune
cmauneforce-pushed the add-created-timestamp branch from 9722c9a to 748472dCompareSeptember 3, 2025 11:27
…uf protocol
Signed-off-by: cmaune <you@example.com>
@cmaune
cmauneforce-pushed the add-created-timestamp branch from 748472d to 0ff3024CompareSeptember 3, 2025 11:30
@cmaune

Copy link
Copy Markdown
ContributorAuthor

@zeitlinger sorry for the delay.
I updated the PR and fixed the integration test failing due to the new property (created_timestamp).
In debug-protobuf.txt i added placeholders for the dynamic values and im replacing them in the "quoted" string regex with "\d+" now.
However i have here several build problems (flaky tests like HistogramTests (#1084) and other build problems (coverage check complains here at prometheus-metrics-instrumentation-jvm)
=> i was only successfull in running mvn clean install with -Dcoverage.skip=true and a disabled HistogramTest.

Hopefully the pipeline will succeed. Thx

@zeitlinger

Copy link
Copy Markdown
Member

mvn clean install

works for me locally - but I've also had that in the past sometimes

@zeitlinger
zeitlinger merged commit b89a721 into prometheus:mainSep 3, 2025
7 checks passed
This was referenced Mar 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaune@zeitlinger