Skip to content

Add Histogram to empty data points test coverage - #1899

Closed
jaydeluca with Copilot wants to merge 2 commits into
exclude-empty-datapointfrom
copilot/sub-pr-1898
Closed

Add Histogram to empty data points test coverage#1899
jaydeluca with Copilot wants to merge 2 commits into
exclude-empty-datapointfrom
copilot/sub-pr-1898

Conversation

CopilotAI commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

metricsWithoutDataPointsAreNotExported lacked Histogram coverage despite MetricDataFactory.create(HistogramSnapshot) already handling empty data points by returning null.

Changes

  • ExportTest.java: Added Histogram to metricsWithoutDataPointsAreNotExported to document and verify the expected no-export behavior alongside the other metric types (Counter, Gauge, Summary, StateSet, Info)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: jaydeluca <7630696+jaydeluca@users.noreply.github.com>

CopilotAI commented Feb 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.1/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.1/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.1/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/client_java/.codeql-scratch/dbs/java/working/files-to-index5695262523355091228.list --sourceArchiveDir=/home/REDACTED/work/client_java/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/client_java/.codeql-scratch/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

CopilotAI changed the title [WIP] Update handling of empty datapoints in otel exporterAdd Histogram to empty data points test coverageFeb 19, 2026
CopilotAI requested a review from jaydelucaFebruary 19, 2026 16:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jaydeluca