Uh oh!
There was an error while loading. Please reload this page.
feat: Add skeleton OpenMetrics2TextFormatWriter - #1951
Merged
Conversation
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a first-pass OpenMetrics 2.0 text writer and wires it into format selection so OM2 can be preferred when OM2 feature flags are enabled (while currently emitting OM1-identical output for compatibility).
Changes:
- Introduce
OpenMetrics2TextFormatWriter(OM2 skeleton) with configurable content-type behavior based onOpenMetrics2Properties. - Update
ExpositionFormatsto construct/expose the OM2 writer and prefer it over OM1 when any OM2 flag is enabled. - Add unit tests for OM2 writer content-type behavior and OM1/OM2 output equivalence; extend
ExpositionFormatsTestfor OM2 selection.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/OpenMetrics2TextFormatWriter.java | New OM2 writer (currently OM1-equivalent output) + content-type switching via OM2 properties. |
| prometheus-metrics-exposition-textformats/src/main/java/io/prometheus/metrics/expositionformats/ExpositionFormats.java | Construct/expose OM2 writer; prefer OM2 over OM1 when OM2 flags enabled; add init(PrometheusProperties) and deprecate old init. |
| prometheus-metrics-exporter-common/src/main/java/io/prometheus/metrics/exporter/common/PrometheusScrapeHandler.java | Switch to initializing ExpositionFormats with full PrometheusProperties. |
| prometheus-metrics-exposition-textformats/src/test/java/io/prometheus/metrics/expositionformats/OpenMetrics2TextFormatWriterTest.java | New tests for OM2 content-type behavior and output parity with OM1. |
| prometheus-metrics-exposition-textformats/src/test/java/io/prometheus/metrics/expositionformats/ExpositionFormatsTest.java | Add OM2 writer existence + selection/preference tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
jaydeluca
marked this pull request as ready for review
March 16, 2026 18:54
zeitlinger
approved these changes
Mar 17, 2026
| private boolean isOpenMetrics2Enabled() { | ||
| OpenMetrics2Properties props = openMetrics2TextFormatWriter.getOpenMetrics2Properties(); | ||
| return props.getContentNegotiation() |
Member
There was a problem hiding this comment.
note: need to add another one if you just want to have the features from #1942
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#1948
BEGIN_COMMIT_OVERRIDE
chore: Add skeleton OpenMetrics2TextFormatWriter
END_COMMIT_OVERRIDE