Skip to content

Support new asgiref - #1081

Open
shadchin wants to merge 3 commits into
prometheus:masterfrom
shadchin:new_asgiref
Open

Support new asgiref#1081
shadchin wants to merge 3 commits into
prometheus:masterfrom
shadchin:new_asgiref

Conversation

@shadchin

Copy link
Copy Markdown

Signed-off-by: Alexander Shadchin <shadchin@yandex-team.com>
@shadchin
shadchinforce-pushed the new_asgiref branch 2 times, most recently from 900e975 to f86c811CompareDecember 18, 2024 09:06
Signed-off-by: Alexander Shadchin <shadchin@yandex-team.com>
Signed-off-by: Alexander Shadchin <alexandr.shadchin@gmail.com>
Comment threadtests/test_asgi.py
self.seed_app(app)
# Send input with gzip header.
self.scope["headers"] = [(b"accept-encoding", b"gzip")]
self.seed_app(app)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason these are reordered?

Comment threadtox.ini
attrs
{py3.9,pypy3.9}: twisted
# NOTE: Pinned due to https://github.com/prometheus/client_python/issues/1020
py3.9: asgiref==3.7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to break for users running on asgiref==3.7?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/test_asgi.py failures with python 3.12

2 participants

@shadchin@csmarchbanks