Uh oh!
There was an error while loading. Please reload this page.
fix: use tuples instead of packaging Version - #1136
Conversation
efiop
commented
Sep 11, 2025
csmarchbanks
left a comment
There was a problem hiding this comment.
Ideally we wouldn't have this dependency, I just missed it during reviews. It is fairly basic parsing and I will look into replacing the package with just an inlined function, unless you would like to first of course!
592738c to
4d90571Compareefiop
commented
Sep 11, 2025
@csmarchbanks removed packaging in favor of simple tuples, i think that should be enough. |
212c950 to
c2011aeCompare| if not version_str: | ||
| return (0, 0, 0) | ||
| try: | ||
| return tuple(int(x) for x in version_str.split('.')) |
There was a problem hiding this comment.
I'm not sure if we have to expect some odd version here or if they are all normal and will convert to int.
882326f to
e0b9a60CompareSigned-off-by: Ruslan Kuprieiev <kupruser@gmail.com>
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks! A couple things I think we should support just to be on the safe side:
- a
vprefix should be stripped off, it doesn't perfectly match the specs but seems silly to not recognize the version if it is present. - A build version, e.g. the third part has
-rc.0or something like that. Similarly, just strip it off the third part.
A test for a few different permutations of versions would be great as well
csmarchbanks
commented
Sep 16, 2025
Just a friendly bump on my previous comments. I can also do the modifications myself if you do not have the time! |
Uh oh!
There was an error while loading. Please reload this page.
Fixes#1135