Uh oh!
There was an error while loading. Please reload this page.
fix: make test suite pass on Windows and Python 3.12+ - #1185
Merged
Conversation
MelvinjoseC
commented
Jun 25, 2026
Contributor
- Fix event loop issues in ASGI tests under newer asgiref by wrapping communicator setup in an async coroutine run on the loop.
- Fix mmap file locking (PermissionError: [WinError 32]) on Windows in multiprocess tests by closing open database handles before unlinking/removing directories.
- Skip case-sensitive env var deprecation warning assertion on Windows where environment variables are case-insensitive.
- Conditionally define the parser benchmark test to avoid failure when pytest-benchmark is not installed.
- Fix event loop issues in ASGI tests under newer asgiref by wrapping communicator setup in an async coroutine run on the loop. - Fix mmap file locking (PermissionError: [WinError 32]) on Windows in multiprocess tests by closing open database handles before unlinking/removing directories. - Skip case-sensitive env var deprecation warning assertion on Windows where environment variables are case-insensitive. - Conditionally define the parser benchmark test to avoid failure when pytest-benchmark is not installed. Signed-off-by: MelvinjoseC <165891174+MelvinjoseC@users.noreply.github.com>
MelvinjoseC
commented
Jul 13, 2026
ContributorAuthor
Thanks for the feedback! I've fixed the remaining lint/type issues and added a Windows CI job using Python 3.12. All local checks pass, and GitHub Actions are now running. |
csmarchbanks
commented
Jul 15, 2026
Member
Thanks! Everything looks good now, but the DCO needs to be signed on your most recent commit. |
Signed-off-by: MelvinjoseC <165891174+MelvinjoseC@users.noreply.github.com>
MelvinjoseC
commented
Jul 17, 2026
ContributorAuthor
Thanks! I've added the DCO sign-off to the latest commit. The DCO check is now passing. The remaining CI workflow is awaiting maintainer approval. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.