Annotate few functions and methods

[takeda]

This is related to #491, it doesn't resolve it, but it could be a step into that direction.

This theoretically should not break python 2.7

[takeda]

@csmarchbanks is there a chance to get this merged? Should I update this patch to resolve current conflicts?

[csmarchbanks]

Hello, sorry, I missed this one! Thank you for the PR. I am hoping to review #718 this week, and merge it soon. At that point I believe we can support full typing instead of just the annotations. Would it make sense to wait until after #718 is merged?

[takeda]

Yeah, that's fine.

[takeda]

@csmarchbanks I rebased my code and adapted it to use annotations as 3.6+ is now required. I currently added types that my code is utilizing. This can be used to show how to add types to other parts of the project.

BTW: since types are not used when the code is run and adding typing involves time, the types could be added incrementally over time.

[csmarchbanks]

Awesome, thanks for the update. Generally this is looking pretty good, I left a handful of questions/comments. I completely agree that types should be added incrementally as people use them rather than requiring one big bang commit to add types.

[csmarchbanks]

One small comment that I missed the first time around, otherwise 👍. Thanks!

[csmarchbanks]

This file is actually a copy of http://pypi.python.org/pypi/decorator, you can see the file header for more details. That does mean we should not edit it so as to make future upgrades easier.

[takeda]

I removed it, but out of curiosity. Why is this needed and why contextmanager is used?

For example:

classExceptionCounter:
def__init__(self, counter: "Counter", exception: Type[BaseException]) ->None:
self._counter=counterself._exception=exceptiondef__enter__(self) ->None:
passdef__exit__(self, typ: Optional[Type[BaseException]], value: Optional[BaseException], traceback: Optional[TracebackType]) ->Literal[False]:
ifisinstance(value, self._exception):
self._counter.inc()
returnFalsedef__call__(self, f: "F") ->"F":
defwrapped(func, *args, **kwargs):
withself:
returnfunc(*args, **kwargs)
returndecorate(f, wrapped)

could be (if I understand things correctly):

@contextmanagerdefexception_counter(counter: "Counter", exception: Type[BaseException]) ->None:
try:
yieldexceptexception:
counter.inc()

[csmarchbanks]

You can find the history of the vendored in file in the PR that added it, as well as the linked issue: #91.

I think you probably could restructure the various context managers like you suggest now that we do not support older python versions. I believe that before 3.2 just using @contextmanger would not allow you to use it as a decorator as well so the class was nicer.

[csmarchbanks]

Thanks!