Uh oh!
There was an error while loading. Please reload this page.
feat: add retain() to Family to allow metrics filtering - #196
Open
howardjohn wants to merge 1 commit into
Open
Conversation
howardjohn
commented
Aug 26, 2024
ContributorAuthor
@mxinden what do you think of this approach? |
howardjohnforce-pushed
the
metrics/expiry
branch
from
November 5, 2024 19:28
9ec1f88 to
fb27004Comparehowardjohn
marked this pull request as ready for review
November 5, 2024 19:29
howardjohnforce-pushed
the
metrics/expiry
branch
from
November 5, 2024 19:29
fb27004 to
cb64aceComparehowardjohnforce-pushed
the
metrics/expiry
branch
from
January 16, 2025 23:51
09896cf to
72bc78dCompareretain() to Family to allow metrics filteringSigned-off-by: John Howard <john.howard@solo.io>
howardjohnforce-pushed
the
metrics/expiry
branch
from
January 16, 2025 23:55
72bc78d to
a6babaeComparehowardjohn
commented
Jan 17, 2025
ContributorAuthor
Ok I have fixed this up and added documentation. Should be good to go from my perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #197.
This enables a way to filter metrics by arbitrary logic. The existing
remove()function is not suitable for this, as it requires us to know the entire label set we want to remove. Theclear()function is not as it clears everything.A simple doc test is added, as well as a more complex example that uses a custom counter to track the last-access-time and calls
retainbased on that.