Skip to content

Correctly disable ZFS for test cases - #2182

Merged
SuperQ merged 1 commit into
prometheus:masterfrom
bdrung:fix-disabling-zfs
Oct 28, 2021
Merged

SuperQ merged 1 commit into
prometheus:masterfrom
bdrung:fix-disabling-zfs

Conversation

@bdrung

@bdrung bdrung commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Disable collector/zfs_linux_test.go in case !nozfs is set to completely disable ZFS.

Disable `collector/zfs_linux_test.go` in case `!nozfs` is set to
completely disable ZFS.

Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
@bdrung
bdrung force-pushed the fix-disabling-zfs branch from 816480b to 10f346d Compare October 28, 2021 09:05

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SuperQ
SuperQ merged commit 0dc82ea into prometheus:master Oct 28, 2021
@bdrung
bdrung deleted the fix-disabling-zfs branch October 28, 2021 13:28
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Disable `collector/zfs_linux_test.go` in case `!nozfs` is set to
completely disable ZFS.

Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Disable `collector/zfs_linux_test.go` in case `!nozfs` is set to
completely disable ZFS.

Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants