Escape all illegal chars in metric names. - #3
Merged
Merged
Conversation
E.g. right now there are some metrics with dashes in their names, which cannot be queried through the UI.
There was a problem hiding this comment.
You are omitting the lowercasing. Is that intended?
Member
There was a problem hiding this comment.
To me, the regex looks good. The ^ negates the whole character group.
Member
Author
There was a problem hiding this comment.
Yes, capitals are legal.
On Aug 15, 2013 1:23 PM, "Matt T. Proud" notifications@github.com wrote:
In exporter/gmond_collector.go:
@@ -84,7 +86,7 @@ func (c *gmondCollector) Update() (updates int, err error) {
for _, host := range cluster.Hosts {for _, metric := range host.Metrics {
name := strings.Replace(strings.ToLower(metric.Name), ".", "_", -1)name := illegalCharsRE.ReplaceAllString(metric.Name, "_")You are omitting the lowercasing. Is that intended?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3/files#r5787896
.
Member
|
👍 |
juliusv
added a commit
that referenced
this pull request
Aug 15, 2013
Escape all illegal chars in metric names.
tamcore
pushed a commit
to gitgrave/node_exporter
that referenced
this pull request
Oct 22, 2024
Update example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.g. right now there are some metrics with dashes in their names, which cannot
be queried through the UI.