Skip to content

bcachefs support - #750

Merged
SuperQ merged 1 commit into
prometheus:masterfrom
ananthb:bcachefs
Feb 24, 2026
Merged

SuperQ merged 1 commit into
prometheus:masterfrom
ananthb:bcachefs

Conversation

@ananthb

@ananthb ananthb commented Sep 27, 2025

Copy link
Copy Markdown
Contributor

Add support for parsing bcachefs filesystems from procfs.

Comment thread bcachefs/bcachefs.go Outdated
@SuperQ

SuperQ commented Feb 13, 2026

Copy link
Copy Markdown
Member

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@ananthb
ananthb marked this pull request as ready for review February 13, 2026 20:07
@ananthb ananthb changed the title init bcachefs support bcachefs support Feb 13, 2026
Comment thread bcachefs/get.go Outdated
@ananthb
ananthb requested a review from SuperQ February 24, 2026 10:06
@SuperQ

SuperQ commented Feb 24, 2026

Copy link
Copy Markdown
Member

This looks mostly fine. We tend to avoid buffio scanners and prefer util.ReadFileNoStat as the scanner + stat overhead is a bit much for all the tiny files we read.

Signed-off-by: Ananth Bhaskararaman <antsub@gmail.com>
@SuperQ

SuperQ commented Feb 24, 2026

Copy link
Copy Markdown
Member

If you have any weight with upstream bcachefs, maybe worth getting them to make some slightly more machine friendly proc files. Having to parse K/M/G/etc is a lot of extra work.

@SuperQ
SuperQ merged commit 51a5dd2 into prometheus:master Feb 24, 2026
7 checks passed
@ananthb

ananthb commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

I don't hold sway there but I expected raw values too. It is weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants