feat(xfs): add Linux 7.0 XFS statistics fields - #810
Merged
Merged
Conversation
Member
Author
|
Hi @SuperQ , PTAL, thanks. |
dongjiang1989
force-pushed
the
updata-xfs-for-7.0
branch
from
May 6, 2026 09:58
441a342 to
06d0457
Compare
Member
Author
|
@discordianfish, @SuperQ Hi, I would appreciate your review of this PR. Thank you. |
|
@SuperQ Hope you are well. It looks like we received a bug report around this as well in https://gitlab.com/gitlab-org/omnibus-gitlab/-/work_items/9876. |
Contributor
|
@dongjiang1989 I just tested your PR. Thanks! It does need some further adjustments though, I get this error with Linux 7.0.7: |
Contributor
|
@dongjiang1989 I sent you a PR on your fork to address this. |
dongjiang1989
force-pushed
the
updata-xfs-for-7.0
branch
2 times, most recently
from
May 25, 2026 02:53
384f72f to
821e295
Compare
Member
Author
Thanks @DragonWork Merged |
Member
Author
|
cc @SuperQ , PTAL, when U have time. thanks. |
Signed-off-by: dongjiang <dongjiang1989@126.com>
fix: correct parsing of xfs stats Signed-off-by: dongjiang <dongjiang1989@126.com>
dongjiang1989
force-pushed
the
updata-xfs-for-7.0
branch
from
June 18, 2026 12:15
821e295 to
14a8a6a
Compare
blewis12
added a commit
to grafana/alloy
that referenced
this pull request
Jul 3, 2026
Bumps github.com/prometheus/procfs to v0.21.0 to incorporate [this upstream fix](prometheus/procfs#810) - this fixes the xfs collector in `prometheus.exporter.unix` failing on newer kernels with `strconv.ParseUint: parsing "xpc": invalid syntax` Addresses #6601
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://elixir.bootlin.com/linux/v7.0/source/fs/xfs/xfs_stats.c
Summary
fs/xfs/xfs_stats.c)fibt2,rmapbt,refcntbt,rmapbt_mem,rcbagbt,rtrmapbt,rtrmapbt_mem,rtrefcntbt,rtrefcntbt— each with 15counters (lookup, compare, insrec, delrec, newroot, killroot, increment, decrement, lshift, rshift, split, join, alloc, free, moves)
zoned(gc_read_calls, gc_bytes) andmetafile(inodes, meta)defer_relog(uint64) andgc xpc(uint64) extended precision countersStatsstruct fields for easier referenceTest plan
go vet ./xfs/...passesgo test ./xfs/...passes (TestParseStats, TestReadProcStat, TestReadSysStats)