Skip to content

Adding support for endianness in TypedBuffer codecs - #233

Merged
avalerio-tkd merged 4 commits into
mainfrom
av_typelist_optimizing_103
Mar 19, 2026
Merged

Adding support for endianness in TypedBuffer codecs#233
avalerio-tkd merged 4 commits into
mainfrom
av_typelist_optimizing_103

Conversation

@avalerio-tkd

@avalerio-tkdavalerio-tkd commented Mar 19, 2026

Copy link
Copy Markdown
Contributor
  • Adding endianness protection to the codecs.
  • Moving the Int96 codec to a separate codec class.
  • Small update to TypedBuffer printout.
  • Unitests updated.

@avalerio-tkd
- Adding endianness protection to the codecs.
e0c093b
- Moving the Int96 codec to a separate codec class.
- Small update to TypedBuffer printout.
- Unitests updated.
argmarco-tkd
argmarco-tkd reviewed Mar 19, 2026
View reviewed changes

@argmarco-tkdargmarco-tkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Overall LGTM. Did leave a few comments.

Comment threadsrc/common/bytes_utils.h
Comment threadsrc/common/bytes_utils.h
Comment threadsrc/common/bytes_utils.h
Comment threadsrc/common/bytes_utils_test.cpp
Comment threadsrc/processing/typed_buffer_codecs.h
Comment threadsrc/processing/typed_buffer_codecs.h
@avalerio-tkd
- Reimplemented BytesToString more efficiently.
c1f393f
- Updated comments on Int96 struct.
@avalerio-tkd

avalerio-tkd commented Mar 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks @argmarco-tkd for the careful review as always. Left a few clarification questions for you. Once those are clear, I'll make the changes.

avalerio-tkd
avalerio-tkd commented Mar 19, 2026
View reviewed changes

@avalerio-tkdavalerio-tkd left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Could you PTAL?

Comment threadsrc/common/bytes_utils.h
Comment threadsrc/common/bytes_utils_test.cpp
@avalerio-tkd
- Added unitests for write_le and read_le functions with expected buf…
2ed0c92
…fers.
- Updated comments on code duplication.
argmarco-tkd
argmarco-tkd approved these changes Mar 19, 2026
View reviewed changes

@argmarco-tkdargmarco-tkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turnaround. LGTM - ship it!

Comment threadsrc/common/bytes_utils.h
Comment threadsrc/common/bytes_utils_test.cpp
@avalerio-tkd

avalerio-tkd commented Mar 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks. Updated the comment on UINT32 to clarify why these are kept separate.

Merging.

@avalerio-tkd
avalerio-tkd merged commit cd2ed09 into mainMar 19, 2026
2 checks passed
@avalerio-tkd
avalerio-tkd deleted the av_typelist_optimizing_103 branch March 19, 2026 17:05
@avalerio-tkdavalerio-tkd mentioned this pull request Mar 19, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sofia-tekdatumsofia-tekdatumAwaiting requested review from sofia-tekdatum
1 more reviewer
@argmarco-tkdargmarco-tkdargmarco-tkd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avalerio-tkd@argmarco-tkd