Skip to content

fix: #8 window is undefined error - #106

Merged
dibenede merged 5 commits into
protocolbuffers:mainfrom
alias-rahil:fix/issues/8
Jul 27, 2022
Merged

fix: #8 window is undefined error#106
dibenede merged 5 commits into
protocolbuffers:mainfrom
alias-rahil:fix/issues/8

Conversation

@alias-rahil

@alias-rahilalias-rahil commented Jun 1, 2022

Copy link
Copy Markdown

Closes#8. Fixes the issue by explicitly checking if window is defined.

NOTE: This PR is similar to the old repo PR protocolbuffers/protobuf#9156 by @marnixbouhuis

@google-cla

google-claBot commented Jun 1, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment threadgenerator/js_generator.cc Outdated
Comment threadgenerator/js_generator.cc Outdated
Comment threadgenerator/js_generator.cc Outdated
@dibenede
dibenede merged commit c3db2b5 into protocolbuffers:mainJul 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The generated commonjs *_pb.js files don't work in Node.js environment

3 participants

@alias-rahil@lukesandberg@dibenede