Uh oh!
There was an error while loading. Please reload this page.
adding simple JSONP support - #294
Open
jwestbrook wants to merge 1 commit into
Open
Conversation
This should add transparent JSONP support to all browsers that PrototypeJS supports.
savetheclocktower
commented
May 5, 2015
Collaborator
Let's pencil this in for 1.8. |
jwestbrook
commented
May 5, 2015
CollaboratorAuthor
no worries - had this PR sitting on my laptop and seeing all the updates reminded me to open this. |
savetheclocktower
commented
Apr 8, 2017
Collaborator
Despite jQuery's way of handling this, I'm hesitant to make it part of |
jwestbrook
commented
Apr 9, 2017
CollaboratorAuthor
actually that would make it very clear if the dev was expecting JSONP to use the JSONPRequest method (and don't name it JSONRequest thats confusing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #197 , this should add transparent JSONP support to all browsers that PrototypeJS supports.
I added unit tests for a cross domain url but was exactly sure how to make WEBrick do it correctly.