Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 19, 2026. It is now read-only.
Only enable minimum set of wasmtime features - #27
Open
alexsnaps wants to merge 2 commits into
Open
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
alexsnaps
commented
Sep 18, 2024
ContributorAuthor
(Crap, I'll redo this PR with my RH, Google CLA approved email), will also update the other deps) |
Signed-off-by: Alex Snaps <asnaps@redhat.com>
Signed-off-by: Alex Snaps <alex@wcgw.dev>
ContributorAuthor
Actually don't think that outdated dep is "fixable": given: Where And I'm not even sure it actually gets pulled in, according to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated wasmtime to the latest release and removed some of the otherwise default features that are actually not needed afaict
Some introduce the need for "newer" toolchains (e.g.
wat) that might be an issue for some test environments out there, despite the dependency actually not being required.