docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

docs(review): correct the token claim in the merged #272 review#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pseudoseed merged 1 commit into from
Aug 31, 2026
Merged

docs(review): correct the token claim in the merged #272 review #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions codev/reviews/272-the-sidebar-tree-needs-every-w.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,23 @@ Claude raised four non-blocking items:
written — acknowledged, not fixed here.** The sweeper is interval plumbing over
`reconcileWorkspaceProjects`, which is covered; the untested part is `start`/`stop`/overlap
behaviour. Worth a follow-up rather than widening this PR.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, and a behaviour
change worth knowing.** A pairing-issued one-time token is now spent on the first tick, before
anyone spawns. The constraint is pre-documented on `ThreadBackendConfig.bootstrapToken`, but this
makes an unbounded desktop seed effectively mandatory for any workspace carrying a `threads`
config. Not changed here because caching a credential across processes is a storage decision.
3. **The sweep re-exchanges the bootstrap token every 30s per server — real, but not for the
reason first recorded here. Corrected.** This originally said a pairing-issued one-time token is
spent on the first tick before anyone spawns, and that an unbounded desktop seed is therefore
effectively mandatory. **That is wrong.** The architect verified against a live server that the
token is durable and re-exchangeable: nothing is burned. The real cost is smaller and different —
each exchange mints a **session**, so the sweep accumulates one per server every 30s and they
pile up. That is a leak, not a spent credential, and it wants a different fix: reuse the access
token across ticks, rather than provisioning a different kind of credential. Tracked in **#306**.

Left visible rather than silently rewritten, because the wrong version was merged and someone
may have read it. The lesson underneath is the one this repo already keeps: a constraint
documented in a comment (`ThreadBackendConfig.bootstrapToken`) is not a measurement, and I
propagated it as though it were.
4. **A down server logs a WARN every 30s, ~2,880 lines/day — real.** Logging on state change is the
fix; deferred as a follow-up rather than folded in.
fix; deferred as a follow-up rather than folded in. Tracked in **#307**.

Items 2-4 need issues; I did not open them because that call is the architect's.
Items 2-4 are filed: **#308** (untested sweeper lifecycle), **#306**, **#307**.

## How to Test Locally

Expand Down
Loading