a lot of housekeeping by zomfg · Pull Request #413 · psieg/Lightpack

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg · 2020-11-26T21:38:46Z

I ran the build through clazy and it highlighted a lot of small things (still does) to improve
here are most of those things:

QStringLiteral (compile time QString basically)
new connect syntax so slots/signals are checked at build time (found few loose things this way)
- which in some cases needs c++14, so I bumped everything to 17
  also apparently doing this through FLAGS does not work well because qmake would still append whatever the default is from mkspec, so changing this via CONFIG solves that
some missing consts
std::chrono_literals for QTimers
QList::reserve() where possible
random normal gcc/clang warnings (casts etc)

After that I tried building with Qt6 RC, and after some minor massaging it worked

QSettings assumes utf-8 now, so no need for setIniCodec() (which is dropped from core anyway)
QRegExp* is QRegularExpression* now
QListworks slightly differently now and does not like forward declarations for item types
I'm not sure if there's more to be done for this part given what they say (like is it leaking as is or...)
couple other minor things

but just by itself this PR has like 95% of the above (so just this would not build with Qt6 for ex)

pull updates from gh #408 takes care of it's own problematic parts (they were removed there so I tried to not overstep too much)
led wizard tweaks #363 got some of the clazy treatment too, but there's nothing blocking iirc

once all 3 are merged, another quick pass would be needed (this one should probably go first)

while dealing with slots and signals I did some device refactoring, mostly de-copypasta'd UDP, and fixed couple of small things on the way
there's a lot more to do there, but that'll wait another time

and finally, removed remaining QDekstopWidget usage which I started doing a while ago with some deprecations, but at the time they were saying "use these other classes/methods" which themselves used QDekstopWidget but were not flagged as deprecated for some reason and now everything gets removed in Qt6...
these changes seem to work, but I can't test multiple displays

otherwise this builds and runs on all 3 platforms

psieg

Thanks, just a few small notes

psieg · 2020-12-02T16:07:30Z

 int count = QGuiApplication::screens().count();

- result = QString("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);
+ result = QStringLiteral("%1%2\r\n").arg(CmdResultCountMonitor).arg(count);


When did you swtich to .arg(x,y) and when stick to .arg(X).arg(Y) ?

(QString1, QString2...) (up to 9 i think)
arg(type1).arg(type2)... which is probably equal to (QString(type1), QString(type2)...) allocation wise

psieg · 2020-12-02T16:10:22Z

 	virtual ~LedDeviceAlienFx();
+	QString name() const { return QStringLiteral("lightfx"); }
+	int maxLedsCount();
+	int defaultLedsCount() { return 1; }


just curious, why is the maxLedsCounts in the code file but the defaultLedsCount in the header?

to avoid adding enum header

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

zomfg added 30 commits November 20, 2020 23:39

clazy: qstringliterals, casts, signals/slots, pass by ref
e60407a

clazy: signals/slots, devices, assert fixes
fc1adb1

drgb/virtual devices: const& loop
8e0cd7c

clazy: msvc
8ab6a7a

clazy: minor qmake fixes
fe825d5

clazy: msvc casts
343961a

clazy: mixed const iters
3c264a4

clazy: some reserve()
b058416

clazy: signals/slots
79bab0b

clazy: c++17
5055d07

clazy: new connects
b464611

clazy: d3d10grabber: new connects
515f8eb

clazy: windows sound manager: new connect
8a820c5

qmake c++17
3b2511d

clazy: qtsingleapplication new connects
6c25f8a

clazy: const-char-pointer
bd0724f

clazy: chrono-literals
99319ed

clazy: more chrono literals
0e052bd

clazy: settings window: new connects
35077ba

settings window: less strict system locale
f1f89ca

clazy: lightpack application / grab manager: new connects
d17bf00

qdesktopwidget includes
b34645b

clazy: new connects
e5e29eb

qdesktopwidget include
0a6d3f9

clazy: device: bad emits
273bf0e

clazy: Q_DISABLE_COPY
f13864f

qt includes
5c6ad8c

blue light default ctor
82a22a9

remaining QDesktopWidgets
d4fe3d3

unused qtmetaobject
2095a6c

zomfg added 10 commits November 25, 2020 15:33

clazy: qstrings
2d13fdf

liquid color gen size cast
3daa730

qt6: include Plugin (does not like fw declaration)
e64c8dc

qt6: nativeEventFilter signature
920662c

qt6: regexp class
62a8ab4

qt6: qchecksum
43dd05c

qt6: text codec
a2a6517

clazy: short qstringliterals with args
f04668a

warls / dnrgb: save and use processed colors for diffs
a56bd84

clazy: config device power page: qstringliterals
cb5a594

psieg reviewed Dec 2, 2020
View reviewed changes

zomfg added 2 commits December 4, 2020 22:13

clazy: comments
e83a308

qmake: check for pkg-config
a3d3f4f

psieg merged commit 49f0493 into psieg:masterDec 6, 2020

zomfg deleted the feature/clazy branch December 6, 2020 19:40

Conversation

zomfg commented Nov 26, 2020

Uh oh!

psieg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zomfgDec 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zomfg commented Nov 26, 2020

Uh oh!

psieg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zomfgDec 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zomfg commented Nov 26, 2020

Uh oh!

psieg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zomfgDec 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

zomfgDec 4, 2020•
edited
Loading

zomfgDec 4, 2020•
edited
Loading

zomfgDec 4, 2020•
edited
Loading

zomfgDec 4, 2020•
edited
Loading