Various fixes to RCTView props by aleclarson · Pull Request #234 · ptmt/react-native-macos

aleclarson · 2019-03-18T12:29:24Z

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson · 2019-03-18T12:29:24Z

Fixes#232

move [RCTViewManager checkLayerExists:] to [NSView ensureLayerExists]
enable edge antialiasing only for transforms with perspective
stop setting layer manually in [NSView ensureLayerExists] (let the layer getter call [NSView makeBackingLayer] instead)
never set layer.transform directly except in [RCTView displayLayer:]
call ensureLayerExists before setting any layer-related prop
call ensureLayerExists inside reactSetFrame: so layer props can be set
enforce position and anchorPoint by setting them in [RCTView displayLayer:]
fix [RCTView setBackgroundColor:] strangeness

And rename it to "ensureLayerExists"

Taken from: react/react-native@cbf65f2

We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

Ensure a layer exists before setting these props.

Otherwise, the anchor point won't be set.

Otherwise, the anchorPoint may be reverted to the top-left.

The "setFrame:" method overrides our transform, so it needs to be reapplied.

- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

aleclarson added 9 commits March 18, 2019 08:23

refactor: move "checkLayerExists:" to NSView+React
da36946
And rename it to "ensureLayerExists"

refactor: simplify "ensureLayerExists"
642fad3

Enable edge antialiasing only for transforms with perspective
91f4cb2
Taken from: react/react-native@cbf65f2

fix: "transform" prop of RCTView
b3f6888
We cannot set "layer.transform" directly except from the "displayLayer:" method, because AppKit often sets it without respecting explicit values. For example, the "setFrame:" method is one spot, but there are others.

fix: add "transform" property to NSView
2a2c404
This prevents a crash when a RCTViewManager represents a NSView subclass (instead of a RCTView subclass), which requires the subclass to implement its own "transform" property and override its "displayLayer:" method.

fix: backfaceVisibility and shadow* props
c7a2bc3
Ensure a layer exists before setting these props.

fix: call "ensureLayerExists" wherever a layer is accessed
a8c8218

fix: ensure layer exists in "reactSetFrame:"
905b944
Otherwise, the anchor point won't be set.

fix: set "position" and "anchorPoint" in "displayLayer:"
fa28701
Otherwise, the anchorPoint may be reverted to the top-left.

aleclarson added this to the 0.20.0 milestone Mar 18, 2019

aleclarson mentioned this pull request Mar 18, 2019
UIExplorer: transforms not working with position #232
Open

aleclarson modified the milestones: 0.20.0, 0.19.3 Mar 18, 2019

aleclarson added 2 commits March 19, 2019 13:49

fix: apply _transform in reactSetFrame
572a274
The "setFrame:" method overrides our transform, so it needs to be reapplied.

fix: RCTView setBackgroundColor
33ac749
- The "_backgroundColor" ivar was not being set when called with nil. - The method assumed that the "layer" property could be nullified when "backgroundColor" is nil, which is definitely not the case.

aleclarson mentioned this pull request Mar 19, 2019
Unofficial roadmap #230
Open

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aleclarson commented Mar 18, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading

aleclarson commented Mar 18, 2019•
edited
Loading