- Notifications
You must be signed in to change notification settings - Fork 0
Adopt the Fleet's .secrets/ Convention and Rename SITE_ Env Keys#107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4ade13f
Adopt the fleet's .secrets/ convention and rename SITE_ env keys
ptr727 f6b4a29
Keep the retired secrets/ directory ignored as a migration backstop
ptr727 3af6be3
Fix stale HUGO_BASEURL leak and clarify the CI-only command form
ptr727 4d3c9be
Drop a duplicated 'with' in the SITE_BASE_URL table row
ptr727 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # .secrets | ||
qodo-code-review[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| Nothing under this directory holds a real value except [`example.env`](./example.env), the | ||
| tracked template, and this catalog. `.gitignore` un-ignores exactly those two paths and ignores | ||
| everything else here, so a fresh checkout documents its own required shape without ever | ||
| exposing one. | ||
| ## Real values live on the host, never in the checkout | ||
| Every real value this repo's scripts read comes from `~/.secrets/`, not from this directory. | ||
| `ENV_FILE=<name> deploy/make-release.sh` and `ops/install.sh` both resolve a relative `ENV_FILE` | ||
| against `$HOME/.secrets`, refuse a traversing one, and default to | ||
| `~/.secrets/Blog.local.production.env`. `~/.secrets/` is shared across every repo on the host, | ||
| so each of this repo's files carries the `Blog.` prefix: | ||
| | File | Selects | | ||
| | --- | --- | | ||
| | `~/.secrets/Blog.local.production.env` | The default, read when `ENV_FILE` is unset. | | ||
| | `~/.secrets/Blog.local.staging.env` | The local staging mirror. | | ||
| | `~/.secrets/Blog.vps.production.env` | The VPS production environment. | | ||
| | `~/.secrets/Blog.vps.staging.env` | The VPS staging environment. | | ||
| Every value each file holds, and what reads it, is described once in | ||
| [`ENVIRONMENT.md`](../ENVIRONMENT.md). Start a new one from [`example.env`](./example.env). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.