Retire the R numbering that the matcher rename orphaned - #8
Merged
Conversation
Re-deriving the redirect table replaced the R1 to R11 numbering with the Caddy matcher names, but only in the table. Two references to the old scheme survived elsewhere, pointing at labels that are now defined nowhere in the repo. Both found by review on the promotion. `checks/check-url-parity.py` printed "resolve after the R8 rewrite" and named "the R8 rewrite prefix" in its failure text. That script is the source of the line quoted in the audit, so it was the actual origin of the orphan rather than a second copy of it. Both strings now name `@uploads`, and the quoted output in `reports/Blog/audit.md` is updated from a real run rather than edited to match. `TODO.md` described an open decision as "a one-line change to rule R3", which is now the `@date_archive` rule. Matcher names were chosen precisely because they can be grepped against the Caddyfile, and that only holds if nothing still refers to the numbering they replaced. Verified: 514 pages, 328/328 render, 778/778 media, 1012/1012 assets. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR completes the repo-wide transition from legacy redirect “R#” identifiers to Caddy matcher names by removing orphaned references left behind after the redirect-table rewrite, keeping diagnostics and documentation grep-aligned with the live Caddyfile.
Changes:
- Updated
checks/check-url-parity.pymedia-gate output to refer to@uploadsinstead of the retiredR8label. - Refreshed the audit report quote to match the updated script output (
@uploads). - Updated
TODO.mdto reference the@date_archivematcher instead of the retiredR3label.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TODO.md | Replaces the retired R3 reference with the @date_archive matcher name. |
| reports/Blog/audit.md | Updates the embedded output snippet to match the current checker output (@uploads). |
| checks/check-url-parity.py | Renames human-facing diagnostics from R8 to @uploads to match the Caddyfile matcher. |
Uh oh!
There was an error while loading. Please reload this page.
The item asked whether the legacy date archives should redirect to `/all/` rather than `/`. The Caddyfile already does exactly that, in `redir @date_archive /all/ 301`, and the redirect table documents the class as landing on `/all/`. So the entry was not an open decision but a record of one already made, which is worse than no entry: it sends a reader hunting for a change that is in effect, and it contradicts the config and the table. Raised by review, which noticed the config and the backlog disagreed. Rewording it to name `@date_archive` in the previous commit made the contradiction easier to see, since it now pointed at the exact rule that already behaved the way the item was asking for. The remaining decisions were checked against the config for the same defect. The `/robots.txt/` and `/osd.xml/` entry is genuinely open, since both still resolve to `/` in `slugs.map`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-deriving the redirect table in #6 replaced the R1 to R11 numbering with Caddy matcher names, but only in the table. Two references survived elsewhere, pointing at labels now defined nowhere in the repo. Both found by review on the promotion, #7.
checks/check-url-parity.pyprintedresolve after the R8 rewriteand namedthe R8 rewrite prefixin its failure text. That script is the source of the line quoted in the audit, so it was the origin of the orphan rather than a second copy of it. Both strings now name@uploads.reports/Blog/audit.mdquotes that output, and the quote is updated from a real run rather than edited to match.TODO.mddescribed an open decision as "a one-line change to rule R3", now the@date_archiverule.Matcher names were chosen precisely because they can be grepped against the Caddyfile, and that only holds if nothing still refers to the numbering they replaced.
Verified after the change: 514 pages, 328/328 render, 778/778 media, 1012/1012 assets.
Once this reaches
develop, the promotion #7 picks it up automatically, since its head isdevelop.