Record two container-testing traps in Verification Discipline - #170
Merged
Conversation
Both surfaced while verifying the version history default against the develop image, and both produce a passing-looking result from a test that never ran. Device Builder's filesystem scanner is gated on WebSocket subscriber presence, so a headless "edit a YAML and wait" test observes a scanner that is parked. The first disabled-case run looked like a pass for the wrong reason; the enabled-case control was equally silent, which is what exposed it. docker cp into the tmpfs-backed /tmp writes underneath the mount, so a helper script staged there is absent at runtime. A subscriber that was never started still reported success. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Records two verification pitfalls encountered while testing Device Builder behavior in containers, strengthening the repo's "Verification Discipline" guidance to prevent false-positive test results.
Changes:
- Document that Device Builder's filesystem scan for external YAML edits is gated by having an active WebSocket subscriber.
- Document that
docker cpinto a tmpfs-backed path (e.g.,/tmp) can write underneath the mount and be invisible at runtime, causing silent no-ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two traps found while verifying the version history default (#169) against the published
developimage. Both are recorded because both produced a passing-looking result from a test that never actually ran.Scanner is gated on WebSocket subscriber presence. Device Builder's background poll for external YAML edits parks when no client is subscribed. A headless "edit a file, wait, observe no commit" test therefore proves nothing - it watched a scanner that was never running. This was caught only because the enabled-case control was also silent, which is the signal that the harness rather than the feature was off. With a subscriber attached the control commits immediately, unsigned and under the fabricated identity, and the disabled case stays clean.
docker cpinto atmpfs-backed path writes underneath the mount. The compose stack mountstmpfsat/tmp; a helper script copied there is absent at runtime, and the step depending on it silently no-ops while still reporting success.Docs only - no behavior change.
🤖 Generated with Claude Code