Re-sync workflows from template and trim parser comments - #189

Merged
ptr727 merged 3 commits into
mainfrom
develop
Jun 24, 2026
Merged

Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom
develop

Conversation

@ptr727

@ptr727ptr727 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.

Template re-sync (dd19d31)

Addresses ptr727/ProjectTemplate#203.

  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.

Comment cleanup (e104dbb)

Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.

(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)

Verification

  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.

🤖 Generated with Claude Code

dependabotBotand others added 3 commits June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings June 24, 2026 04:42
CopilotAI reviewed Jun 24, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.

Changes:

  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.

@ptr727
ptr727 merged commit 001602c into mainJun 24, 2026
16 checks passed
This was referenced Jun 29, 2026
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Re-sync workflows from template and trim parser comments - #189
Merged
ptr727 merged 3 commits into
mainfrom 
develop
Jun 24, 2026
Merged
Re-sync workflows from template and trim parser comments#189
ptr727 merged 3 commits into
mainfrom 
develop
Conversation
@ptr727
@ptr727ptr727
commented
Jun 24, 2026

Copy link


Copy Markdown

Owner
Maintenance-only promotion of develop to main. No version.json change, so main advances only its NBGV height.
Template re-sync (dd19d31)
Addresses ptr727/ProjectTemplate#203.
  • Artifact cleanup. Add a terminal cleanup-artifacts job to publish-release.yml (needs setup/publish/date-badge) and test-pull-request.yml (needs smoke-build) so a run's artifacts are deleted via the REST API instead of accumulating against the small account-wide storage quota. Best-effort: continue-on-error, always(), kept out of the required status check.
  • Name-pattern handoff (decided option a). Converge the github-release handoff to the canonical form: build-nugetlibrary-task.yml uploads release-asset-<branch>-nugetlibrary and drops the artifact-id output/plumbing; build-release-task.yml downloads by pattern: + merge-multiple:. This keeps the github-release job a verbatim carry rather than forking its download step.
  • AGENTS.md. Document both in the Workflow YAML Conventions section so this single-target repo stops drifting back to the id-based variant.
Comment cleanup (e104dbb)
Strip inline comments that only restate self-evident code from LanguageTagParser.cs and LanguageLookup.cs, per the "comment only when the code does not explain itself" rule. RFC 5646 section URLs, ABNF grammar, fallback-chain labels, and "why" notes are kept. Removing one trailing // Done unblocked analyzer IDE0046, collapsing the tail of Validate() to a single expression.
(Also carries the earlier Bump the nuget-deps group dependency PR already on develop.)
Verification
  • dotnet format style --severity=info exit 0, CSharpier clean, 257/257 tests pass.
  • All workflows YAML-valid; CRLF endings preserved.
🤖 Generated with Claude Code
dependabotBotand others
added 3 commits
June 23, 2026 23:03
@dependabot
Bump the nuget-deps group with 1 update (#188)
3a9ed9b
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest)
from 18.6.0 to 18.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's
releases](https://github.com/microsoft/vstest/releases)._
## 18.7.0
## What's Changed
* Add ARM64 msdia140.dll support to test platform packages by
@​jamesmcroft in microsoft/vstest#15689
* Update System.Memory from 4.5.5 to 4.6.3 by @​nohwnd in
microsoft/vstest#15706
## New Contributors
* @​jamesmcroft made their first contribution in
microsoft/vstest#15689
**Full Changelog**:
microsoft/vstest@v18.6.0...v18.7.0
Commits viewable in [compare
view](microsoft/vstest@v18.6.0...v18.7.0).
</details>
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.NET.Test.Sdk&package-manager=nuget&previous-version=18.6.0&new-version=18.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ptr727@claude
Re-sync from template: artifact cleanup + name-pattern handoff
dd19d31
Carry the template's artifact-storage hygiene into the workflows:
- Add a terminal `cleanup-artifacts` job to publish-release.yml
(needs setup/publish/date-badge) and test-pull-request.yml
(needs smoke-build) so a run's artifacts are deleted via the REST
API instead of accumulating against the account-wide storage quota.
- Converge the github-release handoff to the canonical name-pattern
form (ptr727/ProjectTemplate#203, decided option a): build-nugetlibrary
uploads `release-asset-<branch>-nugetlibrary` and drops the `artifact-id`
output/plumbing; build-release downloads by `pattern:` + `merge-multiple:`.
This keeps the github-release job a verbatim carry.
- Document both in AGENTS.md (Workflow YAML Conventions) so this
single-target repo stops drifting back to the id-based variant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ptr727@claude
Remove noise comments from parser and lookup
e104dbb
Strip inline comments that only restate self-evident code (`// Done`,
`// Sort variants`, `// Add … tag`, the SetCase casing labels, etc.)
per the AGENTS.md "comment only when the code does not explain itself"
rule. RFC 5646 section URLs, ABNF grammar blocks, fallback-chain labels,
and any "why" notes are kept.
Removing a trailing `// Done` unblocked analyzer IDE0046 at the end of
Validate(), so the final `if (…) return false; return true;` collapses
to a single `return !string.IsNullOrEmpty(…);` (required: the husky gate
runs `dotnet format style --severity=info`).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CopilotAI
review requested due to automatic review settings
June 24, 2026 04:42
CopilotAI
reviewed
Jun 24, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Maintenance-only promotion that re-syncs GitHub Actions workflows with the upstream template and trims self-evident inline comments in core parsing/lookup code, while also carrying a small test dependency bump.
Changes:
  • Reworked release-asset artifact handoff to a pattern-based download (release-asset-<branch>-*) and removed the artifact-id output plumbing.
  • Added terminal cleanup-artifacts jobs to delete run artifacts via the REST API to reduce account-wide artifact storage accumulation.
  • Removed redundant inline comments in LanguageTagParser / LanguageLookup and simplified the tail of LanguageTagParser.Validate(); bumped Microsoft.NET.Test.Sdk to 18.7.0.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
FileDescription
LanguageTags/LanguageTagParser.csRemoves redundant comments and simplifies Validate()’s final empty-tag check without changing behavior.
LanguageTags/LanguageLookup.csRemoves self-evident inline comments while keeping behavior unchanged.
Directory.Packages.propsBumps Microsoft.NET.Test.Sdk from 18.6.0 to 18.7.0.
AGENTS.mdDocuments the canonical artifact handoff pattern and the new cleanup-artifacts convention.
.github/workflows/test-pull-request.ymlAdds best-effort cleanup-artifacts job to delete any run artifacts without gating the required status check.
.github/workflows/publish-release.ymlAdds best-effort cleanup-artifacts job gated to real publishes to delete run artifacts after publishing.
.github/workflows/build-release-task.ymlSwitches GitHub release asset download to pattern-based download-artifact with merge-multiple.
.github/workflows/build-nugetlibrary-task.ymlRenames uploaded artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs.
@ptr727
ptr727
merged commit 001602c
into
mainJun 24, 2026

16 checks passed


This was referenced Jun 29, 2026
 Merged

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727