Conversation
Bumps the actions-deps group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…actions-deps-a331d3ec2d Bump actions/checkout from 4 to 5 in the actions-deps group
Bumps csharpier from 1.1.1 to 1.1.2 Bumps xunit.analyzers from 1.23.0 to 1.24.0 Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: xunit.analyzers dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…p/nuget-deps-0259308462 Bump the nuget-deps group with 3 updates
Bumps AwesomeAssertions from 9.1.0 to 9.2.0 --- updated-dependencies: - dependency-name: AwesomeAssertions dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…/develop/nuget-deps-8d55c5cab2 Bump the nuget-deps group with 1 update
Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5 --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…/develop/nuget-deps-6aadeae1b1 Bump the nuget-deps group with 1 update
Bumps csharpier from 1.1.2 to 1.2.1 Bumps husky from 0.7.2 to 0.8.0 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: husky dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…p/nuget-deps-c72c7bc702 Bump csharpier and husky
--- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…e/develop/nuget-deps-602f419b37 Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1
Bumps csharpier from 1.2.1 to 1.2.3 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…p/nuget-deps-1689e99d0a Bump the nuget-deps group with 1 update
Bumps the actions-deps group with 3 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [actions/checkout](https://github.com/actions/checkout) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/setup-dotnet` from 4 to 5 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `peter-evans/create-pull-request` from 7 to 8 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps csharpier from 1.2.3 to 1.2.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…p/nuget-deps-133b2bc611 Bump the nuget-deps group with 1 update
Bumps csharpier from 1.2.4 to 1.2.5 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com>
…p/nuget-deps-262ca43251 Bump the nuget-deps group with 1 update
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the LanguageTags library to version 1.1 with .NET 10 and AOT support, along with significant refactoring of the public API surface to minimize internal exposure and improve the API design.
Key changes:
- Upgrades target framework from .NET 9.0 to .NET 10.0 across all projects
- Enables nullable reference types and comprehensive code analysis
- Refactors API visibility (makes many members internal, exposes factory methods)
- Extracts nested record types to top-level for better API design
- Replaces Debug.Assert with proper exception throwing for validation
- Adds comprehensive XML documentation for all public APIs
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Bumps version from 1.0 to 1.1 |
| README.md | Adds version history and updates all code examples to reflect new API design |
| LanguageTags.csproj | Enables .NET 10, AOT compatibility, nullable reference types, and XML documentation |
| LanguageTagsTests.csproj | Upgrades to .NET 10, enables nullable and analyzers |
| LanguageTagsCreate.csproj | Upgrades to .NET 10, enables PublishAot and nullable |
| LanguageTag.cs | Adds factory methods, IEquatable implementation, makes constructors internal, exposes immutable collections |
| LanguageTagParser.cs | Made internal, improved error handling, added ConfigureAwait |
| LanguageTagBuilder.cs | Adds XML documentation, parameter validation, updates to use IEnumerable |
| Rfc5646Data.cs | Extracts Rfc5646Record to top-level, improves validation, adds XML docs |
| Iso6392Data.cs | Extracts Iso6392Record to top-level, improves validation, adds XML docs |
| Iso6393Data.cs | Extracts Iso6393Record to top-level, improves validation, adds XML docs |
| LanguageSchema.cs | New file with code generation helpers and JSON source generation context |
| LanguageLookup.cs | Adds new comparison methods, improves encapsulation |
| Test files | Removes IClassFixture pattern, adds nullable annotations, expands test coverage |
| Configuration files | Updates .NET version references, removes IDE0055 exclusion |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.