Conversation
* Develop (#60) * Bump actions/checkout from 4 to 5 in the actions-deps group Bumps the actions-deps group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 3 updates Bumps csharpier from 1.1.1 to 1.1.2 Bumps xunit.analyzers from 1.23.0 to 1.24.0 Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: xunit.analyzers dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps AwesomeAssertions from 9.1.0 to 9.2.0 --- updated-dependencies: - dependency-name: AwesomeAssertions dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5 --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump csharpier and husky Bumps csharpier from 1.1.2 to 1.2.1 Bumps husky from 0.7.2 to 0.8.0 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: husky dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1 --- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Update dependencies * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.1 to 1.2.3 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the actions-deps group across 1 directory with 3 updates (#48) Bumps the actions-deps group with 3 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [actions/checkout](https://github.com/actions/checkout) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/setup-dotnet` from 4 to 5 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `peter-evans/create-pull-request` from 7 to 8 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.3 to 1.2.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.4 to 1.2.5 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Add AOT support, document code and add test cases with help from copilot * Add version history * readme * Fix missing `},` and enable docs generation * dotnet 10 * install husky * lf * crlf --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update language data and generated files (#61) Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> * Merge remote-tracking branch 'origin/develop'
* Develop (#60) * Bump actions/checkout from 4 to 5 in the actions-deps group Bumps the actions-deps group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 3 updates Bumps csharpier from 1.1.1 to 1.1.2 Bumps xunit.analyzers from 1.23.0 to 1.24.0 Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: xunit.analyzers dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps AwesomeAssertions from 9.1.0 to 9.2.0 --- updated-dependencies: - dependency-name: AwesomeAssertions dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5 --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump csharpier and husky Bumps csharpier from 1.1.2 to 1.2.1 Bumps husky from 0.7.2 to 0.8.0 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: husky dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1 --- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Update dependencies * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.1 to 1.2.3 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the actions-deps group across 1 directory with 3 updates (#48) Bumps the actions-deps group with 3 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [actions/checkout](https://github.com/actions/checkout) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/setup-dotnet` from 4 to 5 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `peter-evans/create-pull-request` from 7 to 8 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.3 to 1.2.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.4 to 1.2.5 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Add AOT support, document code and add test cases with help from copilot * Add version history * readme * Fix missing `},` and enable docs generation * dotnet 10 * install husky * lf * crlf --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update language data and generated files (#61) Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> * Refactor and enhance language tag library - Change Rfc5646Record to a sealed record for better encapsulation. - Add tests for null or empty input handling in Iso6392 and Iso6393. - Enhance LanguageLookupTests with case-insensitive tag comparison and validation for null inputs. - Extend LanguageTagBuilderTests to include multiple variant additions and null checks. - Improve LanguageTagTests with new tests for ExtensionTag and PrivateUseTag constructors and equality. - Add tests for Rfc5646Data to check file date and null input handling. - Update README.md for improved clarity on build status, usage, and references. * Refactor language tag classes to be sealed and improve logging and command line handling - Changed `Iso6392Data`, `Iso6393Data`, and `Rfc5646Data` classes to be sealed for better performance and clarity. - Updated logging configuration to use Serilog with improved context handling. - Introduced a new command line interface for downloading and generating language tag data. - Added options for configuring logging behavior and file paths. - Implemented data downloading and JSON conversion in a structured manner. - Removed unused namespaces and improved code organization across various files. - Added global usings and simplified test project structure. * Refactor LanguageTags library to support asynchronous operations and enhanced logging - Updated LanguageSchema to provide asynchronous file writing with WriteFileAsync. - Enhanced LanguageTag and LanguageTagParser to support parsing with logging options. - Introduced LogOptions for global logging configuration and integrated logging into parsing and data loading processes. - Converted data loading and saving methods in Rfc5646Data, Iso6392Data, and Iso6393Data to asynchronous counterparts. - Added unit tests for asynchronous loading and saving of JSON data for Iso6392Data, Iso6393Data, and Rfc5646Data. - Improved CreateTagData to utilize asynchronous methods for data conversion and code generation. * Update README to reflect asynchronous loading methods and add debug log configuration examples * Update documentation * Refactor and enhance language tag handling - Updated launch configuration to include a trailing comma for args. - Added new language tags "ANTLR" and "datebadge" to the workspace. - Improved asynchronous file handling in Iso6392Data and Iso6393Data classes by using await using for file streams. - Simplified record parsing logic in Iso6392Data and Iso6393Data to reduce redundancy. - Enhanced error handling for invalid records in both classes. - Updated Rfc5646Data to improve async file operations and error logging. - Refactored CreateTagData to streamline HTTP stream handling and file writing. - Modified ExtensionTag to return an empty string when tags are empty. - Added unit test for ExtensionTag to verify empty tag behavior. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates LanguageTags to v1.2, refactors file/data IO to async-only APIs, introduces configurable logging (global and per-call), and modernizes the CLI/codegen workflow plus CI automation.
Changes:
- Bump library version to 1.2 and update documentation/release history accordingly.
- Refactor data load/save/codegen to stream-based async APIs and add
Options/LogOptionslogging configuration. - Rework
LanguageTagsCreateCLI and GitHub Actions workflows for release, codegen PRs, and PR validation.
Reviewed changes
Copilot reviewed 63 out of 66 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Bumps project version to 1.2. |
| README.md | Refreshes documentation: badges, installation, logging, async APIs, and usage sections. |
| LanguageTagsTests/Rfc5646Tests.cs | Updates tests to async load APIs; adds JSON roundtrip and null/empty find tests. |
| LanguageTagsTests/LanguageTagsTests.csproj | Simplifies test project properties; removes packaging metadata. |
| LanguageTagsTests/LanguageTagTests.cs | Adds tests for ExtensionTag/PrivateUseTag constructors and behavior. |
| LanguageTagsTests/LanguageTagParserTests.cs | Switches to global usings for test dependencies. |
| LanguageTagsTests/LanguageTagBuilderTests.cs | Adds argument-null tests and variant range tests for builder APIs. |
| LanguageTagsTests/LanguageLookupTests.cs | Adds equivalence tests, overrides mutability test, and null-arg tests. |
| LanguageTagsTests/Iso6393Tests.cs | Updates to async APIs; adds JSON roundtrip and null/empty find tests. |
| LanguageTagsTests/Iso6392Tests.cs | Updates to async APIs; adds JSON roundtrip and null/empty find tests. |
| LanguageTagsTests/GlobalUsings.cs | Introduces global usings for test project (xUnit/AwesomeAssertions + common BCL). |
| LanguageTagsTests/Fixture.cs | Switches to global usings for test dependencies. |
| LanguageTagsCreate/Program.cs | Refactors CLI entrypoint to System.CommandLine + logging initialization + codegen orchestration. |
| LanguageTagsCreate/LoggerFactory.cs | Adds Serilog-based logger factory integration for CLI and library logging setup. |
| LanguageTagsCreate/LanguageTagsCreate.csproj | Updates dependencies (logging, resilience, commandline), adjusts AOT settings. |
| LanguageTagsCreate/HttpClientFactory.cs | Adds resilient HttpClient creation and handler pipeline configuration. |
| LanguageTagsCreate/GlobalUsings.cs | Adds global usings for the codegen CLI project. |
| LanguageTagsCreate/Extensions.cs | Adds logging-related extension helpers for Serilog + MEL. |
| LanguageTagsCreate/CreateTagData.cs | Extracts codegen steps into a dedicated type (download → JSON → codegen). |
| LanguageTagsCreate/CommandLine.cs | Adds System.CommandLine parsing and execution wiring. |
| LanguageTagsCreate/AssemblyInfo.cs | Adds assembly metadata helpers for user-agent/version reporting. |
| LanguageTagsCreate/.editorconfig | Adds local analyzer suppression configuration for the CLI project. |
| LanguageTags/Rfc5646DataGen.cs | Adjusts generated data type to sealed partial to match API changes. |
| LanguageTags/Rfc5646Data.cs | Converts registry I/O + codegen to async streaming; adds logging hooks and options overloads. |
| LanguageTags/Options.cs | Adds public Options type for per-call/per-instance logging configuration. |
| LanguageTags/LogOptions.cs | Adds global logging configuration and logger creation helpers. |
| LanguageTags/LanguageTags.csproj | Adds logging abstractions dependency; removes Husky restore target. |
| LanguageTags/LanguageTagParser.cs | Adds logging on parse failures/normalization; refactors extensions/private-use handling to immutable records. |
| LanguageTags/LanguageTagBuilder.cs | Seals builder; updates extension/private-use handling; adds options overload for Normalize. |
| LanguageTags/LanguageTag.cs | Seals type; adds options overloads; refactors ExtensionTag/PrivateUseTag into records with normalization helpers. |
| LanguageTags/LanguageSchema.cs | Converts file writing helper to async. |
| LanguageTags/LanguageLookup.cs | Converts to primary constructor w/ logger; adds debug logging and equivalence helpers. |
| LanguageTags/Iso6393Data.cs | Converts ISO 639-3 I/O + codegen to async streaming; adds logging + options overloads. |
| LanguageTags/Iso6392DataGen.cs | Adjusts generated data type to sealed partial to match API changes. |
| LanguageTags/Iso6392Data.cs | Converts ISO 639-2 I/O + codegen to async streaming; adds logging + options overloads. |
| LanguageTags/GlobalUsings.cs | Adds global usings for the library project. |
| LanguageTags/Extensions.cs | Adds strongly-typed LoggerMessage helpers for library operations. |
| LanguageTags/.editorconfig | Adds local analyzer suppression configuration for the library project. |
| LanguageTags.code-workspace | Updates cSpell words and default solution reference. |
| LanguageData/iso6393.json | Updates ISO 639-3 data content. |
| LanguageData/iso6393 | Updates ISO 639-3 source data content. |
| LICENSE | Updates copyright year. |
| HISTORY.md | Adds release history document (including v1.2 notes). |
| CODESTYLE.md | Adds coding standards/tooling documentation. |
| AGENTS.md | Adds contributor/agent guidance and project overview pointers. |
| .vscode/tasks.json | Updates build task wiring and dependencies. |
| .vscode/launch.json | Updates launch args to match new CLI --codepath requirement. |
| .husky/pre-commit | Adds Husky pre-commit hook runner script. |
| .gitignore | Adds additional ignore patterns. |
| .github/workflows/update-languagedata.yml | Removes old periodic data update workflow. |
| .github/workflows/test-task.yml | Removes old test workflow. |
| .github/workflows/test-release-task.yml | Adds new test workflow composition for release pipeline validation. |
| .github/workflows/test-pull-request.yml | Adds PR workflow invoking the release test task and status check. |
| .github/workflows/test-pr.yml | Removes old PR test workflow. |
| .github/workflows/run-periodic-codegen-pull-request.yml | Adds new scheduled weekly codegen PR workflow. |
| .github/workflows/run-codegen-pull-request-task.yml | Adds reusable workflow task to run codegen + open PR. |
| .github/workflows/publish-release.yml | Refactors release publishing to use reusable build tasks + date badge job. |
| .github/workflows/merge-bot-pull-request.yml | Refactors merge automation and tightens conditions for bot merges. |
| .github/workflows/get-version-task.yml | Adds reusable workflow to compute Nerdbank.GitVersioning outputs. |
| .github/workflows/build-release-task.yml | Adds reusable workflow for building and optionally publishing GitHub/NuGet releases. |
| .github/workflows/build-library-task.yml | Adds reusable workflow to build library artifacts and optionally push to NuGet. |
| .github/workflows/build-datebadge-task.yml | Adds reusable workflow to publish a BYOB “last build” badge. |
| .github/dependabot.yml | Removes dependabot config for develop branch updates. |
| .github/copilot-instructions.md | Updates project instructions to reflect v1.2 APIs and workflow changes. |
| .config/dotnet-tools.json | Adds dotnet-outdated-tool to tool manifest. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…d equality checks (#70) - Added normalization methods for ExtensionTag and PrivateUseTag to ensure consistent casing and ordering of tags. - Implemented equality checks and hash code generation for ExtensionTag and PrivateUseTag. - Updated LanguageTagBuilder to throw an exception for empty extension tags. - Enhanced validation in LanguageTagParser to reject whitespace in extension tags. - Added tests to verify new behaviors and ensure robustness.
…ling in Iso6392Data, Iso6393Data, and Rfc5646Data classes; add tests for LanguageTag parsing and normalization with options; implement logging options tests. (#71)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Enhance the LanguageTags library with improved encapsulation, asynchronous operations, and logging capabilities. Update various dependencies, including actions and nuget packages, while also refining documentation and adding tests for new functionalities. Address issues related to husky installation and improve error handling in language tag processing.
ptr727
disabled auto-merge
January 30, 2026 04:37
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 30, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.