Conversation
* Develop (#60) * Bump actions/checkout from 4 to 5 in the actions-deps group Bumps the actions-deps group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 3 updates Bumps csharpier from 1.1.1 to 1.1.2 Bumps xunit.analyzers from 1.23.0 to 1.24.0 Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: xunit.analyzers dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps AwesomeAssertions from 9.1.0 to 9.2.0 --- updated-dependencies: - dependency-name: AwesomeAssertions dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5 --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump csharpier and husky Bumps csharpier from 1.1.2 to 1.2.1 Bumps husky from 0.7.2 to 0.8.0 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: husky dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1 --- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Update dependencies * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.1 to 1.2.3 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the actions-deps group across 1 directory with 3 updates (#48) Bumps the actions-deps group with 3 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [actions/checkout](https://github.com/actions/checkout) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/setup-dotnet` from 4 to 5 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `peter-evans/create-pull-request` from 7 to 8 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.3 to 1.2.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.4 to 1.2.5 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Add AOT support, document code and add test cases with help from copilot * Add version history * readme * Fix missing `},` and enable docs generation * dotnet 10 * install husky * lf * crlf --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update language data and generated files (#61) Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> * Merge remote-tracking branch 'origin/develop'
* Develop (#60) * Bump actions/checkout from 4 to 5 in the actions-deps group Bumps the actions-deps group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 3 updates Bumps csharpier from 1.1.1 to 1.1.2 Bumps xunit.analyzers from 1.23.0 to 1.24.0 Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps - dependency-name: xunit.analyzers dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps AwesomeAssertions from 9.1.0 to 9.2.0 --- updated-dependencies: - dependency-name: AwesomeAssertions dependency-version: 9.2.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5 --- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 3.1.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump csharpier and husky Bumps csharpier from 1.1.2 to 1.2.1 Bumps husky from 0.7.2 to 0.8.0 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps - dependency-name: husky dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1 --- updated-dependencies: - dependency-name: Serilog.Sinks.Console dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Update dependencies * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.1 to 1.2.3 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the actions-deps group across 1 directory with 3 updates (#48) Bumps the actions-deps group with 3 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [actions/checkout](https://github.com/actions/checkout) and [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request). Updates `actions/setup-dotnet` from 4 to 5 - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) Updates `actions/checkout` from 5 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) Updates `peter-evans/create-pull-request` from 7 to 8 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions-deps ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.3 to 1.2.4 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Bump the nuget-deps group with 1 update Bumps csharpier from 1.2.4 to 1.2.5 --- updated-dependencies: - dependency-name: csharpier dependency-version: 1.2.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget-deps ... Signed-off-by: dependabot[bot] <support@github.com> * Add AOT support, document code and add test cases with help from copilot * Add version history * readme * Fix missing `},` and enable docs generation * dotnet 10 * install husky * lf * crlf --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update language data and generated files (#61) Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> * Refactor and enhance language tag library - Change Rfc5646Record to a sealed record for better encapsulation. - Add tests for null or empty input handling in Iso6392 and Iso6393. - Enhance LanguageLookupTests with case-insensitive tag comparison and validation for null inputs. - Extend LanguageTagBuilderTests to include multiple variant additions and null checks. - Improve LanguageTagTests with new tests for ExtensionTag and PrivateUseTag constructors and equality. - Add tests for Rfc5646Data to check file date and null input handling. - Update README.md for improved clarity on build status, usage, and references. * Refactor language tag classes to be sealed and improve logging and command line handling - Changed `Iso6392Data`, `Iso6393Data`, and `Rfc5646Data` classes to be sealed for better performance and clarity. - Updated logging configuration to use Serilog with improved context handling. - Introduced a new command line interface for downloading and generating language tag data. - Added options for configuring logging behavior and file paths. - Implemented data downloading and JSON conversion in a structured manner. - Removed unused namespaces and improved code organization across various files. - Added global usings and simplified test project structure. * Refactor LanguageTags library to support asynchronous operations and enhanced logging - Updated LanguageSchema to provide asynchronous file writing with WriteFileAsync. - Enhanced LanguageTag and LanguageTagParser to support parsing with logging options. - Introduced LogOptions for global logging configuration and integrated logging into parsing and data loading processes. - Converted data loading and saving methods in Rfc5646Data, Iso6392Data, and Iso6393Data to asynchronous counterparts. - Added unit tests for asynchronous loading and saving of JSON data for Iso6392Data, Iso6393Data, and Rfc5646Data. - Improved CreateTagData to utilize asynchronous methods for data conversion and code generation. * Update README to reflect asynchronous loading methods and add debug log configuration examples * Update documentation * Refactor and enhance language tag handling - Updated launch configuration to include a trailing comma for args. - Added new language tags "ANTLR" and "datebadge" to the workspace. - Improved asynchronous file handling in Iso6392Data and Iso6393Data classes by using await using for file streams. - Simplified record parsing logic in Iso6392Data and Iso6393Data to reduce redundancy. - Enhanced error handling for invalid records in both classes. - Updated Rfc5646Data to improve async file operations and error logging. - Refactored CreateTagData to streamline HTTP stream handling and file writing. - Modified ExtensionTag to return an empty string when tags are empty. - Added unit test for ExtensionTag to verify empty tag behavior. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…d equality checks (#70) - Added normalization methods for ExtensionTag and PrivateUseTag to ensure consistent casing and ordering of tags. - Implemented equality checks and hash code generation for ExtensionTag and PrivateUseTag. - Updated LanguageTagBuilder to throw an exception for empty extension tags. - Enhanced validation in LanguageTagParser to reject whitespace in extension tags. - Added tests to verify new behaviors and ensure robustness.
…ling in Iso6392Data, Iso6393Data, and Rfc5646Data classes; add tests for LanguageTag parsing and normalization with options; implement logging options tests. (#71)
Enhance the LanguageTags library with improved encapsulation, asynchronous operations, and logging capabilities. Update various dependencies, including actions and nuget packages, while also refining documentation and adding tests for new functionalities. Address issues related to husky installation and improve error handling in language tag processing.
#73) …y in project files
ptr727
enabled auto-merge (squash)
January 30, 2026 05:31
ptr727
disabled auto-merge
January 30, 2026 05:35
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates LanguageTags for the 1.2 release by refactoring I/O to async streaming APIs, adding configurable logging, modernizing the codegen CLI and CI workflows, and refreshing documentation/test coverage.
Changes:
- Version bump to 1.2 plus updated README/HISTORY/docs reflecting new async-only I/O APIs and logging support.
- Core library refactor: async Load/Save/CodeGen, new
Options/LogOptions, expanded logging throughout parsing/lookup/data loading. - CI/CD + codegen updates: new modular GitHub Actions tasks/workflows and improved
LanguageTagsCreateCLI (command-line parsing + resilient HTTP).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Bumps NerdBank.GitVersioning version to 1.2. |
| README.md | Major rewrite: new badges/links, updated API examples, release notes pointer. |
| LanguageTagsTests/Rfc5646Tests.cs | Updates tests for async APIs; adds round-trip JSON tests. |
| LanguageTagsTests/LogOptionsTests.cs | Adds unit tests for global/per-call logging behavior. |
| LanguageTagsTests/LanguageTagsTests.csproj | Updates test project config and moves to xUnit v3 packages. |
| LanguageTagsTests/LanguageTagTests.cs | Adds option-aware parse/normalize tests and equality tests for tag records. |
| LanguageTagsTests/LanguageTagParserTests.cs | Adds parser failure case for whitespace extension tags. |
| LanguageTagsTests/LanguageTagBuilderTests.cs | Adds option-aware normalize + new argument validation tests. |
| LanguageTagsTests/LanguageLookupTests.cs | Adds tests for equivalence helpers, overrides, and null-guard behavior. |
| LanguageTagsTests/Iso6393Tests.cs | Updates tests for async APIs; adds JSON round-trip tests and null/empty Find tests. |
| LanguageTagsTests/Iso6392Tests.cs | Updates tests for async APIs; adds JSON round-trip tests and null/empty Find tests. |
| LanguageTagsTests/GlobalUsings.cs | Introduces global usings for tests to reduce per-file usings. |
| LanguageTagsTests/Fixture.cs | Adds collection definition to disable parallelization for static logging tests. |
| LanguageTagsCreate/Program.cs | Refactors CLI entrypoint; wires command parsing, logging, and execution flow. |
| LanguageTagsCreate/LoggerFactory.cs | Adds Serilog-based logger factory helper for the CLI. |
| LanguageTagsCreate/LanguageTagsCreate.csproj | Updates CLI dependencies (System.CommandLine, resilience, logging); adjusts AOT settings. |
| LanguageTagsCreate/HttpClientFactory.cs | Adds resilient HttpClient (retry/circuit breaker/timeout) for downloads. |
| LanguageTagsCreate/GlobalUsings.cs | Adds global usings for CLI project. |
| LanguageTagsCreate/Extensions.cs | Adds logging/exception helper extensions for CLI logging. |
| LanguageTagsCreate/CreateTagData.cs | Extracts codegen workflow: download → JSON → generated code, all async. |
| LanguageTagsCreate/CommandLine.cs | Adds System.CommandLine-based option parsing and root command wiring. |
| LanguageTagsCreate/AssemblyInfo.cs | Adds assembly metadata helpers (name/version/build type). |
| LanguageTagsCreate/.editorconfig | Project-level analyzer overrides for CLI project. |
| LanguageTags/Rfc5646DataGen.cs | Updates generated data class to sealed partial. |
| LanguageTags/Rfc5646Data.cs | Converts to async streaming load/save/codegen; adds logging hooks; seals types. |
| LanguageTags/Options.cs | Adds public Options type for per-call/per-instance logging configuration. |
| LanguageTags/LogOptions.cs | Adds global logging configuration and logger selection logic. |
| LanguageTags/LanguageTags.csproj | Adds logging abstractions dependency; updates SourceLink; enables XML docs. |
| LanguageTags/LanguageTagParser.cs | Adds options-aware logging; normalizes extension/private-use handling; updates validation. |
| LanguageTags/LanguageTagBuilder.cs | Seals builder; validates extension tags non-empty; adds options-aware Normalize overload. |
| LanguageTags/LanguageTag.cs | Seals LanguageTag; adds options-aware parse/normalize APIs; converts extension/private-use to records. |
| LanguageTags/LanguageSchema.cs | Makes file writing async (used by schema/codegen helpers). |
| LanguageTags/LanguageLookup.cs | Adds options-aware logging; adds equivalence helper methods; minor behavior logging. |
| LanguageTags/Iso6393DataGen.cs | Updates generated type to sealed partial; incorporates updated ISO 639-3 data. |
| LanguageTags/Iso6393Data.cs | Converts to async streaming load/save/codegen; adds logging and options overloads; seals types. |
| LanguageTags/Iso6392DataGen.cs | Updates generated type to sealed partial. |
| LanguageTags/Iso6392Data.cs | Converts to async streaming load/save/codegen; adds logging and options overloads; seals types. |
| LanguageTags/GlobalUsings.cs | Adds global usings for the library project. |
| LanguageTags/Extensions.cs | Adds library logging extensions and structured log messages. |
| LanguageTags/.editorconfig | Adds project-specific analyzer suppressions/config. |
| LanguageTags.code-workspace | Updates workspace settings (default solution, cSpell words). |
| LanguageData/iso6393.json | Updates ISO 639-3 JSON data (new/updated records). |
| LanguageData/iso6393 | Updates ISO 639-3 source data (new/updated records). |
| LICENSE | Updates copyright year. |
| HISTORY.md | Adds release history file including 1.2 notes. |
| CODESTYLE.md | Adds/updates detailed code style & tooling rules. |
| AGENTS.md | Adds repository guidance for coding agents and pointers to standards. |
| .vscode/tasks.json | Updates VS Code tasks (build/format dependency chain). |
| .vscode/launch.json | Updates debug args for CLI (--codepath). |
| .gitignore | Adds common ignore entries (.artifacts, .DS_Store, *.user). |
| .github/workflows/update-languagedata.yml | Removes old language data update workflow. |
| .github/workflows/test-task.yml | Removes old test workflow task. |
| .github/workflows/test-release-task.yml | Adds modular test + release build workflow. |
| .github/workflows/test-pull-request.yml | Adds PR workflow orchestrating test-release with status check workaround. |
| .github/workflows/test-pr.yml | Removes old PR test workflow. |
| .github/workflows/run-periodic-codegen-pull-request.yml | Adds scheduled entry workflow for weekly codegen PRs. |
| .github/workflows/run-codegen-pull-request-task.yml | Adds reusable workflow to run codegen + open PR. |
| .github/workflows/publish-release.yml | Refactors publish workflow to call reusable build/release tasks and date badge generation. |
| .github/workflows/merge-bot-pull-request.yml | Tightens merge-bot conditions; updates branch naming for codegen PRs. |
| .github/workflows/get-version-task.yml | Adds reusable version retrieval task (nbgv). |
| .github/workflows/build-release-task.yml | Adds reusable build+release orchestration task. |
| .github/workflows/build-library-task.yml | Adds reusable build+artifact+optional NuGet push task. |
| .github/workflows/build-datebadge-task.yml | Adds BYOB badge generation task. |
| .github/dependabot.yml | Removes dependabot updates for develop branch. |
| .github/copilot-instructions.md | Updates project documentation and workflow references for 1.2 changes. |
| .config/dotnet-tools.json | Adds dotnet-outdated-tool to tool manifest. |
ptr727 added a commit
that referenced
this pull request
Jan 30, 2026
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.