Skip to content

Refresh hub canonicals and fold CLAUDE.md into AGENTS.md - #18

Merged
ptr727 merged 0 commit into
developfrom
conformance/canonical-refresh
Jul 23, 2026
Merged

Refresh hub canonicals and fold CLAUDE.md into AGENTS.md#18
ptr727 merged 0 commit into
developfrom
conformance/canonical-refresh

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Round-2 canonical refresh of the issue #14 convergence. The hub adopted all seven round-1 feedback items (dispositions on the issue), so the carried copies return to parity with the refreshed canonicals.

  • CODESTYLE.md: re-vendored from hub main - the MD033 fix and the xUnit dynamic-skip carve-out are now canonical upstream (adopted with this repo's wording), and the new "Central Build and Package Configuration" section is carried. Repo adaptations re-applied: InternalsVisibleTo names (PhotoCleanerBenchmarks/PhotoCleanerTests), Python section dropped (no Python here), vscode-tasks reference pointed at ./.vscode/tasks.json, orphaned reference definitions removed.
  • AGENTS.md: "Verification Discipline" re-vendored byte-identical to the hub (gains the never-edit-an-active-code-workspace rule). Repository Details gains the pre-commit verification-set bullet folded from CLAUDE.md.
  • repo-config/configure.sh: verbatim re-vendor (cmp-verified byte-identical); the canonical gained a two-line stdout-suppression rationale in cmd_apply, superseding the declined PR Carry fleet governance baseline from the hub #16 review thread.
  • .github/copilot-instructions.md: hub canonical re-vendored with ptr727/PhotoCleaner substituted (only the per-use <N> placeholder remains). Carries both audit-checked H2s: "Commit Messages and Pull Request Titles" and "GitHub Copilot Review Runbook". The project-architecture content stays as additional sections below the canonical content.
  • CLAUDE.md removed: the import and pointers duplicate AGENTS.md/CODESTYLE.md, and the command block duplicated tasks.json (the canonical command spec). The one unique rule (full pre-commit verification set) is folded into AGENTS.md Repository Details.

Verified already at parity, unchanged: version.json (modulo the repo's 1.0 version floor), repo-config/settings.json (byte-identical), the HISTORY.md opening (mirrors README since #16), and the workspace (no cSpell block since #16).

Closes nothing directly; #13 was closed separately with a pointer to #16.

Verification

  • Verbatim assertions: Verification Discipline section and configure.sh byte-identical to hub main.
  • markdownlint (all .md): 0 issues. editorconfig-checker: exit 0. No code changes (docs/config only); CI runs the full gate.

🤖 Generated with Claude Code

CopilotAI review requested due to automatic review settings July 23, 2026 16:55
@codecov

codecovBot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.96%. Comparing base (8bc46bd) to head (e5147dc).

Additional details and impacted files
@@ Coverage Diff @@## develop #18 +/- ##
========================================
Coverage 44.96% 44.96% ========================================
Files 25 25 Lines 3398 3398 Branches 259 259 ========================================
Hits 1528 1528 Misses 1824 1824 Partials 46 46 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the repo’s governance/canonical documentation to match the upstream hub baseline, consolidating agent guidance into the intended single sources of truth (AGENTS.md / CODESTYLE.md / .github/copilot-instructions.md) and removing redundant guidance.

Changes:

  • Re-vendors Copilot/agent governance guidance, including the Copilot review runbook and verification discipline updates.
  • Updates CODESTYLE.md with the latest canonical wording (including markdownlint MD033 stance and xUnit skip guidance).
  • Removes CLAUDE.md after folding its unique rule into AGENTS.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
FileDescription
repo-config/configure.shAdds rationale comments for stdout suppression during apply operations.
CODESTYLE.mdRefreshes canonical style/verification guidance and adds a new central build/package configuration section.
CLAUDE.mdRemoves redundant agent instructions file.
AGENTS.mdAdds a workspace-edit safety rule and folds in the full verification-set requirement.
.github/copilot-instructions.mdReplaces with refreshed canonical Copilot instructions + review runbook content.

Comment threadCODESTYLE.md
Comment threadrepo-config/configure.sh

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment threadCODESTYLE.md Outdated
CopilotAI review requested due to automatic review settings July 23, 2026 17:04

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged this pull request into developJul 23, 2026
6 checks passed
@ptr727
ptr727 deleted the conformance/canonical-refresh branch July 23, 2026 17:08
ptr727 added a commit that referenced this pull request Aug 3, 2026
* Refresh hub canonicals and fold CLAUDE.md into AGENTS.md
Round-2 canonical refresh (issue #14): the hub adopted the round-1
feedback, so the carried copies return to parity.
- CODESTYLE.md: re-vendor from the refreshed hub canonical (adopted
MD033 fix and dynamic-skip carve-out, new Central Build and Package
Configuration section); repo adaptations re-applied
(InternalsVisibleTo names, Python section dropped, local
vscode-tasks link).
- AGENTS.md: Verification Discipline re-vendored byte-identical,
gaining the never-edit-an-active-code-workspace rule; add the
pre-commit verification-set bullet to Repository Details.
- repo-config/configure.sh: re-vendor verbatim; the new
stdout-suppression rationale supersedes the declined PR #16 thread.
- .github/copilot-instructions.md: re-vendor the hub canonical with
owner/repo substituted, adding the Commit Messages and Pull Request
Titles section and the GitHub Copilot Review Runbook; the project
architecture content stays as additional sections.
- Remove CLAUDE.md: its content is covered by AGENTS.md,
CODESTYLE.md, and tasks.json (the canonical command spec).
version.json, repo-config/settings.json, and the HISTORY.md opening
are already at parity and are unchanged.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Clarify the MD033 note: comments permitted, elements flagged
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727