Pin the publisher checkout to the triggering commit - #24
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## develop #24 +/- ##
========================================
Coverage 44.96% 44.96% ========================================
Files 25 25 Lines 3398 3398 Branches 259 259 ========================================
Hits 1528 1528 Misses 1824 1824 Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the release publisher workflow to pin the reusable workflow checkout/ref to the exact commit that triggered the run, preventing mid-run branch advancement from causing version/build/tag mismatches.
Changes:
- Pass
ref: ${{ github.sha }}(commit SHA) instead ofref: ${{ github.ref_name }}(moving branch tip) into the reusablebuild-release-task.ymlworkflow. - Add inline documentation explaining why the publisher is pinned while still passing
branch: ${{ github.ref_name }}for branch-scoped behavior/config.
Uh oh!
There was an error while loading. Please reload this page.
ptr727 added a commit
that referenced
this pull request
Aug 3, 2026
Adopt the hub canonical's ref: ${{ github.sha }} in publish-release
instead of the moving ref: ${{ github.ref_name }} inherited from the
console+docker reference. This pins get-version, the builds, and the
release tag to the exact commit that triggered the run, so a branch
that advances mid-run cannot shift the published version. branch stays
github.ref_name for config, tags, and prerelease; the publisher builds
one branch per run so GITHUB_REF still matches and NBGV classifies
correctly without IGNORE_GITHUB_REF.
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaced by the promotion PR (#20) review.
publish-release.ymlpassedref: ${{ github.ref_name }}(the branch name, resolved to the moving tip at job runtime) - inherited from the console+docker reference. The hub canonical publisher pinsref: ${{ github.sha }}, the exact commit that triggered the run.ref: ${{ github.sha }}so get-version, the builds, and the release tag all use one commit even if the branch advances mid-run.branchstaysgithub.ref_name(the logical branch for config, tags, prerelease). The publisher builds one branch per run, soGITHUB_REFstill matches the trigger branch and NBGV classifies prerelease correctly without needingIGNORE_GITHUB_REF.This is a case of the fleet reference (PlexCleaner) being behind the hub canonical - conformed to the hub, not the reference.
actionlint clean.
🤖 Generated with Claude Code