Drop the unused nugetPackageVersion block from version.json - #31
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the unused nugetPackageVersion configuration from version.json, aligning the repository’s Nerdbank.GitVersioning config with the fact that PhotoCleaner does not publish a NuGet package (Docker image + GitHub release only).
Changes:
- Delete the
nugetPackageVersionblock fromversion.json. - Keep the
versionfloor andpublicReleaseRefSpecunchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## develop #31 +/- ##
========================================
Coverage 44.96% 44.96% ========================================
Files 25 25 Lines 3398 3398 Branches 259 259 ========================================
Hits 1528 1528 Misses 1824 1824 Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
ptr727 added a commit
that referenced
this pull request
Aug 3, 2026
STANDUP.md section 2 says to carry only the fields the repo uses: nugetPackageVersion is packaging configuration for a NuGet publisher, and this repo publishes a Docker image and a GitHub release, no package. A setting nothing reads is a maintenance surface that outlives whoever knows it is inert. Nothing in the tree references nugetPackageVersion or the NuGetPackageVersion output it shapes, so the build and release versions are unchanged. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not an
audit.pyfinding:version.jsonis carried atintentfidelity, so the mechanical check only asserts the file is present. This comes fromSTANDUP.mdsection 2, "Carry only the fields the repo uses.nugetPackageVersionis packaging configuration for a NuGet publisher, so a repo that publishes no package drops the block rather than carrying a setting nothing reads."This repo publishes a Docker image and a GitHub release. It ships no NuGet package, and the block came in with the baseline carry.
Verification
grepover the tree finds no other reference tonugetPackageVersionor theNuGetPackageVersionoutput it shapes, so the build and release versions are unchanged.version(the 1.0 floor) andpublicReleaseRefSpecare untouched.editorconfig-checkerexits 0.Part of the conformance sweep against the hub baseline (
audit run 2026-08-01T14:29:05Z | hub 6501479).