Skip to content

Adopt the Hub-Hosted Merge-Bot Caller Stub - #53

Merged
ptr727 merged 1 commit into
developfrom
feature/merge-bot-stub
Aug 16, 2026
Merged

Adopt the Hub-Hosted Merge-Bot Caller Stub#53
ptr727 merged 1 commit into
developfrom
feature/merge-bot-stub

Conversation

@ptr727

Copy link
Copy Markdown
Owner

What

Replaces .github/workflows/merge-bot-pull-request.yml with the fleet caller stub, so the merge-bot's three jobs run from the hub's reusable merge-bot-task.yml, pinned to hub release 2.0.338 (20616e0), rather than as a copied 98-line workflow here. Nothing else changes: the pull_request_target trigger, the per-PR concurrency group, and the two App secrets are the same, and no rules or delete-branch input is set because this repository runs no tracker and keeps the default behavior.

Why

This is the stage-1 pilot of the hub's rollout of hub-hosted reusable workflows (ptr727/ProjectTemplate docs/reusable-workflows.md "Rollout"). PhotoCleaner is the pilot because it is a release-model repo with Dependabot, C#, executable and Docker targets, and a recent resync with nothing outstanding, so what it shows is the mechanism rather than the repo. The hub audit already reports this file as owing the caller job (missing required job 'merge-bot'), which is the finding this closes.

What this pilot proves, and how to read it

The hub cannot prove these itself, so they are recorded here as observed once they happen and copied into the hub tracker:

  1. Cross-repository resolution of the owner-scoped uses: pin. The first pull_request_target run after this merges either resolves ptr727/ProjectTemplate/.github/workflows/merge-bot-task.yml@20616e0... or fails at workflow load. Evidence is the run URL.
  2. The callee merges a Dependabot PR to develop with --squash. Evidence is the first Dependabot PR after merge, auto-merged, with the run URL.
  3. Dependabot bumps the pin. The github-actions ecosystem here targets both branches, so the next hub release should produce a Bump ptr727/ProjectTemplate PR. Evidence is that PR.

The rules input is not exercised here (no tracker), that proof falls to homeassistant-purpleair.

Verification

Hub repo_gate.py --root (eol, eol-coverage, sha-pin with the new pin resolved against GitHub), hub prose_lint.py --diff origin/develop, actionlint. The pre-commit hook ran (.NET Format, no changes).

The merge-bot's job bodies now live once in the hub as the reusable
merge-bot-task.yml, released at 2.0.338, and this repository is the
first to reach it rather than carry a copy. The stub keeps the
pull_request_target trigger, the per-PR concurrency group, and grants
GITHUB_TOKEN no scope, since every write in the task uses the App token.
No rules or delete-branch input is set: this repository runs no tracker
and keeps the hub's default behavior.
CopilotAI lite review requested due to automatic review settings August 16, 2026 02:15
@codecov

codecovBot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.37%. Comparing base (ab23034) to head (206b4e5).

Additional details and impacted files
@@ Coverage Diff @@## develop #53 +/- ##
========================================
Coverage 43.37% 43.37% ========================================
Files 28 28 Lines 3896 3896 Branches 306 306 ========================================
Hits 1690 1690 Misses 2154 2154 Partials 52 52 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PhotoCleaner’s merge-bot GitHub Actions workflow to use the fleet’s hub-hosted reusable workflow (merge-bot-task.yml) pinned to hub release 2.0.338 (20616e0...), replacing the previously in-repo, fully inlined workflow while keeping the same pull_request_target trigger semantics and per-PR concurrency behavior.

Changes:

  • Replace the local merge-bot-pull-request.yml job implementation with a thin uses: caller to ptr727/ProjectTemplate/.github/workflows/merge-bot-task.yml@20616e0....
  • Preserve pull_request_target trigger types and PR-scoped concurrency (including cancel-in-progress: false).
  • Explicitly set permissions: {} in the caller, relying on the hub workflow’s GitHub App token for writes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ptr727
ptr727 merged commit a3158ce into developAug 16, 2026
16 checks passed
@ptr727
ptr727 deleted the feature/merge-bot-stub branch August 16, 2026 02:26
ptr727 added a commit to ptr727/ProjectTemplate that referenced this pull request Aug 16, 2026
…ts (#752)
## What
- `docs/reusable-workflows.md` Rollout: stage 1 names PhotoCleaner as
the pilot, adopted on `develop` in ptr727/PhotoCleaner#53 at `a3158ce`
(audit clean on that branch), ticking on promotion to its ground-truth
branch per the tracker's own rule, with two proof items (the first
`pull_request_target` run resolving the pin and merging a Dependabot PR,
and Dependabot bumping the pin). HomeAutomation-Config moves to the
operational slot. Stages 2 and 4 put PhotoCleaner first as well.
- `TODO.md`: the cluster's pilot line and the sweep entry's outstanding
count follow.
- `reports/workflow-reuse.md` regenerated at this hub state
(PhotoCleaner still counts as a copy there because its ground truth is
`main`).
## Why
The maintainer chose PhotoCleaner as the first repo to test with:
release model, Dependabot, C#, executable and Docker targets, recently
converged, so what it shows is the mechanism rather than the repo. The
tracker is the record a cold session resumes from, so the choice and its
state land in git.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727