Re-vendor the .github/skills/ Tree from the Hub - #87
Conversation
python3 scripts/carry.py apply PhotoCleaner: 26 files stale against the current hub canonical re-vendored verbatim, plus 3 new skills the hub added (drive-pr, local-strict-review, merge-and-release). Fully hub-owned tree, no repo-local content to preserve. Audit run 2026-08-29T01:09:26Z | hub b823bc4
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (27)
Comment |
PR Summary by QodoRe-vendor Hub Skills and Add PR Lifecycle Workflows
AI Description
Diagram
High-Level Assessment
Files changed (27) |
Code Review by Qodo
1. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are documentation-only hub re-vendors, and the only issue found is a minor title-case example inconsistency with an inline fix suggestion already provided.
Pull request overview
This PR re-vendors the repository’s .github/skills/ distribution from the hub canonical as part of the periodic fleet resync, refreshing existing skill documentation and adding newly introduced skills.
Changes:
- Re-vendor and update multiple existing skills to match current hub guidance (review loop, resync/standup procedures, workflows/releases, style guidance).
- Add new skills:
drive-pr,local-strict-review, andmerge-and-release. - Refine several references to clarify “hub-owned” vs “downstream-carried” responsibilities (e.g.,
repo-config//settings/ruleset guidance, lint/tooling notes).
File summaries
| File | Description |
|---|---|
| .github/skills/workflow-ci-contract/SKILL.md | Updates CI/workflow contract wording and clarifies ruleset/context naming guidance references. |
| .github/skills/upstream-contribution-workflow/SKILL.md | Adds explicit guidance on when upstream draft PRs are allowed and how to iterate safely. |
| .github/skills/standup-a-repo/SKILL.md | Clarifies configure.sh check then apply flow and how to interpret non-zero check exits. |
| .github/skills/skill-lifecycle/SKILL.md | Tightens lifecycle procedure wording around regenerate/build and commit authorization. |
| .github/skills/shell-codestyle/SKILL.md | Adds explicit shellcheck + shfmt clean-compile rule and broadens scope to extensionless scripts. |
| .github/skills/resync-a-repo/SKILL.md | Adds “file hub defects as issues” guidance and clarifies settings/rulesets/secrets checking procedure. |
| .github/skills/repo-worktree/SKILL.md | Expands worktree/standalone-clone decision criteria and adds clearer cleanup/verification steps. |
| .github/skills/python-codestyle/SKILL.md | Clarifies build vs lint-only profiles across toolchain, commands, CI gates, and testing approach. |
| .github/skills/python-codestyle/references/testing.md | Notes build-profile scope and points lint-only testing to profiles reference. |
| .github/skills/python-codestyle/references/code-style.md | Adds explicit “don’t hedge for older interpreter” rule and enumerates exceptions. |
| .github/skills/pr-review-conduct/SKILL.md | Extends merge gate and loop guidance (coverage nuance, advisory reviewers, draft-state policy, effort metadata). |
| .github/skills/operational-vs-release-workflow/SKILL.md | Adds explicit “worktree cleanup/base clone on develop” end-state guidance. |
| .github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md | Refines release seam mapping guidance (including source-only publish mechanics). |
| .github/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.md | Updates ruleset/configure guidance and improves EOL-conflict resolution command examples. |
| .github/skills/merge-and-release/SKILL.md | New skill documenting the end-to-end promotion merge and optional release dispatch procedure. |
| .github/skills/local-strict-review/SKILL.md | New skill defining a pre-PR adversarial local review pass over the full diff. |
| .github/skills/git-commit-conventions/SKILL.md | Clarifies destructive-command prohibition and documents a narrow post-squash cleanup exception. |
| .github/skills/drive-pr/SKILL.md | New skill for driving PRs through review loops to develop and optionally to a promotion-ready state. |
| .github/skills/dotnet-codestyle/SKILL.md | Strengthens local hook guidance and clarifies CI/local enforcement expectations. |
| .github/skills/dotnet-codestyle/references/project-config.md | Adds explicit Nullable + XML documentation project configuration guidance. |
| .github/skills/dotnet-codestyle/references/conventions.md | Expands XML doc example to include a complete method body with validation/cancellation. |
| .github/skills/copilot-instructions-keeper/SKILL.md | Updates intent-fidelity section coverage and clarifies ledger-preservation rules and references. |
| .github/skills/comment-and-doc-style/SKILL.md | Adds Docker lint authorization guidance; updates carried-doc references and PR-title/title-case examples. |
| .github/skills/comment-and-doc-style/references/line-endings.md | Updates .gitattributes/default normalization guidance and clarifies mixed-consumer handling. |
| .github/skills/comment-and-doc-style/references/carried-doc-references.md | Updates the carried-file scope list to match current carried set. |
| .github/skills/audit-a-repo/SKILL.md | Updates live settings/rulesets/secrets verification guidance to use hub main tools. |
| .github/skills/agent-conduct/SKILL.md | Adds “pre-existing checkout is not ground truth” and “run local-strict-review before PR-bound claims” guidance. |
Review details
- Files reviewed: 27/27 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
🟡 Changes recommended
Several updated skill docs are now internally inconsistent with this repository’s current governance/config (notably repo-config/ scope and .gitattributes/line-ending policy), which would mislead contributors following the updated guidance.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
.github/skills/comment-and-doc-style/references/line-endings.md:67
- This paragraph claims the “paired global LF defaults” remove the need for path-specific pins for extensionless executables, but this repo relies on explicit
.gitattributespins for extensionless scripts like.husky/pre-commit(and uses* -textby default). The guidance should reflect that POSIX-executed scripts still need git-level LF enforcement to avoid CRLF shebang breakage on checkout/renormalize.
Must be LF. A CRLF shebang (`#!/usr/bin/env bash\r`) breaks execution. The paired global LF
defaults cover extensionless executables, shell scripts, and directly executed Python without
path-specific pins. A CRLF-native operational repo adds narrow matching LF overrides in both
files only for scripts it executes on POSIX.
- Files reviewed: 27/27 changed files
- Comments generated: 4
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are documentation-only skill re-vendor updates (plus new skill docs) and review found no correctness, formatting, or consistency defects that would block merge.
Review details
- Files reviewed: 27/27 changed files
- Comments generated: 0 new
- Review effort level: Lite
Uh oh!
There was an error while loading. Please reload this page.
Part of the periodic hub resync (see also the instruction-set and intent-files PRs from the same
run). Audit run
2026-08-29T01:09:26Z | hub b823bc4.python3 scripts/carry.py apply PhotoCleaner: 26 files stale against the current hub canonicalre-vendored verbatim, plus 3 new skills the hub added since the last resync (
drive-pr,local-strict-review,merge-and-release). This tree is fully hub-owned (carry.py's manifest,not the
carried-instruction-file-guardprobe), so no repo-local content is at risk here.🤖 Generated with Claude Code