Skip to content

Re-vendor the .github/skills/ Tree from the Hub - #87

Merged
ptr727 merged 1 commit into
developfrom
chore/hub-resync-skills-tree-2026-08
Aug 29, 2026
Merged

Re-vendor the .github/skills/ Tree from the Hub#87
ptr727 merged 1 commit into
developfrom
chore/hub-resync-skills-tree-2026-08

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Part of the periodic hub resync (see also the instruction-set and intent-files PRs from the same
run). Audit run 2026-08-29T01:09:26Z | hub b823bc4.

python3 scripts/carry.py apply PhotoCleaner: 26 files stale against the current hub canonical
re-vendored verbatim, plus 3 new skills the hub added since the last resync (drive-pr,
local-strict-review, merge-and-release). This tree is fully hub-owned (carry.py's manifest,
not the carried-instruction-file-guard probe), so no repo-local content is at risk here.

🤖 Generated with Claude Code

python3 scripts/carry.py apply PhotoCleaner: 26 files stale against the
current hub canonical re-vendored verbatim, plus 3 new skills the hub
added (drive-pr, local-strict-review, merge-and-release). Fully
hub-owned tree, no repo-local content to preserve.
Audit run 2026-08-29T01:09:26Z | hub b823bc4
CopilotAI lite review requested due to automatic review settings August 29, 2026 01:20
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 2 minutes.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9781a44c-45ff-40a8-b006-f3f7c7471e45

📥 Commits

Reviewing files that changed from the base of the PR and between e453d0a and 4098e3f.

📒 Files selected for processing (27)
  • .github/skills/agent-conduct/SKILL.md
  • .github/skills/audit-a-repo/SKILL.md
  • .github/skills/comment-and-doc-style/SKILL.md
  • .github/skills/comment-and-doc-style/references/carried-doc-references.md
  • .github/skills/comment-and-doc-style/references/line-endings.md
  • .github/skills/copilot-instructions-keeper/SKILL.md
  • .github/skills/dotnet-codestyle/SKILL.md
  • .github/skills/dotnet-codestyle/references/conventions.md
  • .github/skills/dotnet-codestyle/references/project-config.md
  • .github/skills/drive-pr/SKILL.md
  • .github/skills/git-commit-conventions/SKILL.md
  • .github/skills/local-strict-review/SKILL.md
  • .github/skills/merge-and-release/SKILL.md
  • .github/skills/operational-vs-release-workflow/SKILL.md
  • .github/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.md
  • .github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md
  • .github/skills/pr-review-conduct/SKILL.md
  • .github/skills/python-codestyle/SKILL.md
  • .github/skills/python-codestyle/references/code-style.md
  • .github/skills/python-codestyle/references/testing.md
  • .github/skills/repo-worktree/SKILL.md
  • .github/skills/resync-a-repo/SKILL.md
  • .github/skills/shell-codestyle/SKILL.md
  • .github/skills/skill-lifecycle/SKILL.md
  • .github/skills/standup-a-repo/SKILL.md
  • .github/skills/upstream-contribution-workflow/SKILL.md
  • .github/skills/workflow-ci-contract/SKILL.md

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Re-vendor Hub Skills and Add PR Lifecycle Workflows

✨ Enhancement📝 Documentation🕐 20-40 Minutes

Grey Divider

AI Description

• Re-vendors the hub-owned skills tree to the latest canonical guidance.
• Adds workflows for local review, PR driving, and merge-and-release operations.
• Aligns review, worktree, linting, release, and repository-management practices.
Diagram

graph TD
A["Agent Conduct"] --> B["Local Review"] --> C["Drive PR"] --> D["PR Review"] --> E["Merge Release"] --> F["Worktree Cleanup"]
Loading
High-Level Assessment

A full canonical re-vendor is the appropriate approach for a fully hub-owned tree. Selectively applying individual changes was considered but would preserve drift and undermine the manifest-owned synchronization model.

Files changed (27) +687 / -152

Enhancement (3) +428 / -0
SKILL.mdAdd an end-to-end PR driving skill+131/-0

Add an end-to-end PR driving skill

• Introduces a workflow for driving feature and promotion PRs through review, finding disposition, safe squash merges, and branch cleanup. Separates promotion readiness from authorization to merge main.

.github/skills/drive-pr/SKILL.md

SKILL.mdAdd adversarial pre-PR review guidance+72/-0

Add adversarial pre-PR review guidance

• Introduces a read-only full-diff review pass before PR pushes and completion claims. Defines target resolution, untracked-file coverage, reviewer prompting, and finding disposition.

.github/skills/local-strict-review/SKILL.md

SKILL.mdAdd guarded promotion merge and release workflow+225/-0

Add guarded promotion merge and release workflow

• Introduces a gated procedure for merging develop into main, dispatching and correlating releases, refreshing hub-installed skills, and cleaning completed worktrees and branches.

.github/skills/merge-and-release/SKILL.md

Documentation (24) +259 / -152
SKILL.mdStrengthen verification and upstream reporting discipline+4/-1

Strengthen verification and upstream reporting discipline

• Adds safeguards against stale checkouts and ambiguous private-repository reads. Requires local strict review before completion claims and directs hub-governance findings to ProjectTemplate issues.

.github/skills/agent-conduct/SKILL.md

SKILL.mdUse hub-owned configuration checks during audits+1/-1

Use hub-owned configuration checks during audits

• Replaces locally constructed configuration comparisons with the canonical hub checkout, configure script, and audit runner.

.github/skills/audit-a-repo/SKILL.md

SKILL.mdDocument Docker lint authorization and title casing+27/-7

Document Docker lint authorization and title casing

• Defines restricted Docker lint authorization boundaries and agent-specific approval guidance. Narrows carried-file scope and updates PR title examples to the canonical casing style.

.github/skills/comment-and-doc-style/SKILL.md

carried-doc-references.mdNarrow the carried-document reference scope+1/-1

Narrow the carried-document reference scope

• Removes repo-config files from the set governed by carried-document reference restrictions.

.github/skills/comment-and-doc-style/references/carried-doc-references.md

line-endings.mdAlign line-ending guidance with global Git normalization+21/-39

Align line-ending guidance with global Git normalization

• Documents repository-wide LF normalization, CRLF exceptions, paired subtree overrides, and simplified script handling. Clarifies recursive byte-preservation patterns.

.github/skills/comment-and-doc-style/references/line-endings.md

SKILL.mdTrack the fourth Copilot instruction section+9/-9

Track the fourth Copilot instruction section

• Expands intent-file maintenance from three to four named sections and clarifies its relationship to the carried instruction guard.

.github/skills/copilot-instructions-keeper/SKILL.md

SKILL.mdRecommend canonical Husky.Net hooks+5/-4

Recommend canonical Husky.Net hooks

• Changes local .NET hooks from optional to strongly suggested and points repositories to the canonical shared configuration.

.github/skills/dotnet-codestyle/SKILL.md

conventions.mdMake the XML documentation example complete+11/-1

Make the XML documentation example complete

• Replaces an empty method body with a compilable example covering validation, cancellation, asynchronous work, and return behavior.

.github/skills/dotnet-codestyle/references/conventions.md

project-config.mdRequire nullable analysis and XML documentation output+4/-0

Require nullable analysis and XML documentation output

• Adds project configuration guidance for nullable reference types and generated XML documentation files.

.github/skills/dotnet-codestyle/references/project-config.md

SKILL.mdDefine a guarded post-squash branch deletion exception+1/-3

Define a guarded post-squash branch deletion exception

• Allows force-deleting only an exact task branch after live merge verification and a clean-worktree check, while preserving the general destructive-command prohibition.

.github/skills/git-commit-conventions/SKILL.md

SKILL.mdRequire cleanup after merges and releases+1/-0

Require cleanup after merges and releases

• Adds worktree cleanup and base-clone restoration as required terminal steps for merge and release operations.

.github/skills/operational-vs-release-workflow/SKILL.md

branch-protection-and-promotion.mdStandardize hub-driven ruleset configuration+15/-19

Standardize hub-driven ruleset configuration

• Replaces manual ruleset construction with the hub configure script and clarifies promotion safety commands and hub-owned references.

.github/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.md

release-publish-mechanics.mdCorrect reusable release task guidance+7/-9

Correct reusable release task guidance

• Updates artifact naming and documents source-only releases through the hub-hosted reusable release task rather than an inline publisher.

.github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md

SKILL.mdExpand reviewer coverage and local review integration+26/-5

Expand reviewer coverage and local review integration

• Clarifies advisory reviewer signals, comment-only finding shapes, and Copilot effort states. Requires ready PRs, pre-push local strict review, and post-merge cleanup.

.github/skills/pr-review-conduct/SKILL.md

SKILL.mdDifferentiate build and lint-only Python profiles+27/-16

Differentiate build and lint-only Python profiles

• Separates pytest-based build projects from unittest-based lint-only scripts across local, CI, and testing guidance. Strongly recommends the canonical pre-commit hook.

.github/skills/python-codestyle/SKILL.md

code-style.mdDocument the Python 3.13 syntax floor+13/-0

Document the Python 3.13 syntax floor

• Explains why modern syntax needs no compatibility hedging and identifies the limited bootstrap files that intentionally support older interpreters.

.github/skills/python-codestyle/references/code-style.md

testing.mdScope pytest conventions to build profiles+4/-0

Scope pytest conventions to build profiles

• Directs lint-only Scripts profiles to their separate unittest and coverage conventions.

.github/skills/python-codestyle/references/testing.md

SKILL.mdPrefer registered worktrees and formalize cleanup+51/-26

Prefer registered worktrees and formalize cleanup

• Makes registered fleet worktrees the preferred isolation mechanism, with temporary clones only after approval routes fail. Adds provider guidance, standardized hook setup, verified post-merge cleanup, and base-clone restoration.

.github/skills/repo-worktree/SKILL.md

SKILL.mdRoute resync defects upstream and use hub checks+9/-3

Route resync defects upstream and use hub checks

• Requires durable ProjectTemplate issues for hub defects and runs configuration and secret checks from the hub main branch.

.github/skills/resync-a-repo/SKILL.md

SKILL.mdAdd shfmt to the shell clean-compile+9/-2

Add shfmt to the shell clean-compile

• Defines shellcheck plus shfmt as the shell validation gate and includes extensionless shell executables in its scope.

.github/skills/shell-codestyle/SKILL.md

SKILL.mdTie generated skill commits to authorization rules+1/-1

Tie generated skill commits to authorization rules

• Clarifies that regenerated skill distributions are committed only after authorization under the commit conventions.

.github/skills/skill-lifecycle/SKILL.md

SKILL.mdClarify canonical repository configuration reconciliation+6/-3

Clarify canonical repository configuration reconciliation

• Documents check-versus-apply behavior and requires configuration reconciliation from the hub main checkout.

.github/skills/standup-a-repo/SKILL.md

SKILL.mdDefine safe upstream draft PR handling+5/-1

Define safe upstream draft PR handling

• Allows drafts only from a clean presentation branch while keeping iterative work on the separate dirty branch.

.github/skills/upstream-contribution-workflow/SKILL.md

SKILL.mdPoint required checks to hub-owned ruleset payloads+1/-1

Point required checks to hub-owned ruleset payloads

• Clarifies that workflow check names must remain synchronized with the hub's canonical repository configuration payloads.

.github/skills/workflow-ci-contract/SKILL.md

@qodo-code-review

qodo-code-reviewBot commented Aug 29, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2)📘 Rule violations (1)📜 Skill insights (0)

Grey Divider


Action required

1. Invalid source-only release path✗ Dismissed🐞 Bug≡ Correctness
Description
The skill now directs source-only repositories to call the hub's build-release-task.yml, but
WORKFLOW.md explicitly excludes source-only repositories from that reusable workflow and requires a
standalone publisher that inlines NBGV and release creation. Following the added procedure would
produce a workflow that violates the applicable release topology and may be rejected by the reusable
workflow's applicability contract.
Code

.github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md[R99-102]

+- **Source-only / no build** (validate + tag + release): the repo has no leaf build tasks.+ Its dispatch-only `publish-release.yml` calls the hub-hosted `build-release-task.yml` after the repo's reusable validation task succeeds.+ The caller sets `github: true`, every `enable_*` input to false, and `expect_release_assets: false`.+ The reusable task runs NBGV and creates the release with the tag, automatic source archive, README, and LICENSE.
Evidence
The repository's authoritative workflow document states that build-release-task.yml has
appliesTo excluding source-only repositories and prescribes a standalone publish-release.yml.
The added skill text prescribes the opposite architecture.

WORKFLOW.md[289-289]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The source-only release instructions contradict the governing workflow topology.
## Issue Context
WORKFLOW.md says source-only repositories have no `build-release-task.yml` and must inline NBGV and `action-gh-release` in their standalone dispatch workflow.
## Fix Focus Areas
- .github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md[99-102]
- WORKFLOW.md[289-289]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Wrong PyPI artifact name 🐞 Bug≡ Correctness
Description
The release skill renames the PyPI handoff artifact to pypi-build-<branch>, while the governing
workflow contract requires pypilibrary-build-<branch>. Implementing or auditing a workflow from
this skill would make the publisher look for a different artifact than the builder uploads, breaking
publication and cleanup.
Code

.github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md[75]

+ `pypi-build-<branch>` artifact, and the separate `publish-pypi` job in the caller's own
Evidence
WORKFLOW.md defines the PyPI leaf as uploading pypilibrary-build-<branch>, and GOVERNANCE.md says
the publish job deletes that exact artifact after consumption. The newly documented
pypi-build-<branch> therefore cannot satisfy the existing producer/consumer contract.

WORKFLOW.md[286-286]
GOVERNANCE.md[201-201]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The skill uses a PyPI artifact name that disagrees with the repository's workflow contract.
## Issue Context
Both WORKFLOW.md and GOVERNANCE.md identify the handoff and consume-then-delete artifact as `pypilibrary-build-<branch>`.
## Fix Focus Areas
- .github/skills/operational-vs-release-workflow/references/release-publish-mechanics.md[72-77]
- WORKFLOW.md[286-286]
- GOVERNANCE.md[201-201]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


3. Wrong line-ending policy 🐞 Bug≡ Correctness
Description
The skill now says every repository uses * text=auto eol=lf, but this repository's actual
.gitattributes uses * -text plus narrow LF pins. Following the new guidance would cause agents
to rewrite the repository's normalization policy and potentially renormalize unrelated text files.
Code

.github/skills/comment-and-doc-style/references/line-endings.md[R16-18]

+- **`.gitattributes` mirrors the repository-wide defaults**: `* text=auto eol=lf` normalizes every+ detected text file to LF while leaving binary files byte-preserved. `*.bat` and `*.cmd` override+ that default to CRLF. Do not add per-language or per-file LF pins where the global LF default
Evidence
The repository's checked-in policy explicitly disables Git text normalization globally and documents
that .editorconfig controls ordinary file endings; only scripts, uv.lock, and Dockerfiles
receive Git-level LF pins. That directly contradicts the added global text=auto eol=lf
instruction.

.gitattributes[1-16]
.gitattributes[18-31]
.editorconfig[16-29]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The vendored line-ending skill describes a global `text=auto` policy that the repository does not use.
## Issue Context
The checked-in `.gitattributes` uses `* -text` and explicit execution-sensitive LF pins, while `.editorconfig` supplies the general LF default.
## Fix Focus Areas
- .github/skills/comment-and-doc-style/references/line-endings.md[16-24]
- .gitattributes[1-31]
- .editorconfig[16-29]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

4. Capitalize Tree and Hub📘 Rule violation⚙ Maintainability
Description
The PR title Re-vendor the .github/skills/ tree from the hub leaves the major words tree and
hub lowercase instead of using title case. Rename it to `Re-vendor the .github/skills/ Tree from
the Hub`.
Code

.github/skills/comment-and-doc-style/SKILL.md[240]

+Add Structured Logging Extensions to Library
Evidence
PR Compliance ID 2826923 requires major words in pull request titles to be capitalized, while short
bind words such as the and from remain lowercase. The changed title-case examples reinforce that
major nouns are capitalized, but the current PR title lowercases tree and hub.

Rule 2826923: Use title case with lowercase short bind words in pull request titles
.github/skills/comment-and-doc-style/SKILL.md[234-240]


5. Nonexistent shell CI gate✗ Dismissed🐞 Bug☼ Reliability
Description
The skill claims CI enforces shellcheck plus shfmt over standalone shell scripts, but the
authoritative CI list contains neither a standalone-shell check nor shfmt; its bundled
shellcheck only comes from actionlint for workflow run: blocks. Agents can therefore treat
standalone scripts as CI-verified even though the stated clean-compile is not enforced.
Code

.github/skills/shell-codestyle/SKILL.md[R35-38]

+- **`shellcheck` is the linter and `shfmt` the formatter.** The clean-compile is `shellcheck`+ clean at default severity plus `shfmt -d`, both reporting nothing before a commit. CI enforces+ both, per `GOVERNANCE.md` "Running the Linters Locally", and `scripts/docker_lint.py` runs the+ same pair headless. Neither is scoped to the `*.sh` glob alone: a tracked, extension-less
Evidence
GOVERNANCE.md enumerates markdownlint-cli2, cspell, actionlint, editorconfig-checker, and
conditional PSScriptAnalyzer as authoritative CI checks. It further explains that shellcheck is
bundled in actionlint specifically for workflow run: blocks, with no shfmt or standalone-script
gate documented.

GOVERNANCE.md[205-215]
GOVERNANCE.md[223-229]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The shell skill describes shell gates that the repository's current CI contract does not run.
## Issue Context
GOVERNANCE.md lists the authoritative checks and only mentions shellcheck as bundled inside actionlint for workflow shell blocks; it does not define a shfmt gate for standalone scripts.
## Fix Focus Areas
- .github/skills/shell-codestyle/SKILL.md[35-40]
- GOVERNANCE.md[205-229]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 13 rules
Review mode: ⚖️ Balanced: This is a broad hub-owned documentation/skill resync with 27 files and 53 edit sites, including substantial new workflow and release-control procedures; although not runtime code, the many independent behavioral instructions warrant a careful single-pass review, but the diff is not clearly dense orလ

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread.github/skills/comment-and-doc-style/SKILL.md
Comment thread.github/skills/shell-codestyle/SKILL.md

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are documentation-only hub re-vendors, and the only issue found is a minor title-case example inconsistency with an inline fix suggestion already provided.

Pull request overview

This PR re-vendors the repository’s .github/skills/ distribution from the hub canonical as part of the periodic fleet resync, refreshing existing skill documentation and adding newly introduced skills.

Changes:

  • Re-vendor and update multiple existing skills to match current hub guidance (review loop, resync/standup procedures, workflows/releases, style guidance).
  • Add new skills: drive-pr, local-strict-review, and merge-and-release.
  • Refine several references to clarify “hub-owned” vs “downstream-carried” responsibilities (e.g., repo-config//settings/ruleset guidance, lint/tooling notes).
File summaries
FileDescription
.github/skills/workflow-ci-contract/SKILL.mdUpdates CI/workflow contract wording and clarifies ruleset/context naming guidance references.
.github/skills/upstream-contribution-workflow/SKILL.mdAdds explicit guidance on when upstream draft PRs are allowed and how to iterate safely.
.github/skills/standup-a-repo/SKILL.mdClarifies configure.sh check then apply flow and how to interpret non-zero check exits.
.github/skills/skill-lifecycle/SKILL.mdTightens lifecycle procedure wording around regenerate/build and commit authorization.
.github/skills/shell-codestyle/SKILL.mdAdds explicit shellcheck + shfmt clean-compile rule and broadens scope to extensionless scripts.
.github/skills/resync-a-repo/SKILL.mdAdds “file hub defects as issues” guidance and clarifies settings/rulesets/secrets checking procedure.
.github/skills/repo-worktree/SKILL.mdExpands worktree/standalone-clone decision criteria and adds clearer cleanup/verification steps.
.github/skills/python-codestyle/SKILL.mdClarifies build vs lint-only profiles across toolchain, commands, CI gates, and testing approach.
.github/skills/python-codestyle/references/testing.mdNotes build-profile scope and points lint-only testing to profiles reference.
.github/skills/python-codestyle/references/code-style.mdAdds explicit “don’t hedge for older interpreter” rule and enumerates exceptions.
.github/skills/pr-review-conduct/SKILL.mdExtends merge gate and loop guidance (coverage nuance, advisory reviewers, draft-state policy, effort metadata).
.github/skills/operational-vs-release-workflow/SKILL.mdAdds explicit “worktree cleanup/base clone on develop” end-state guidance.
.github/skills/operational-vs-release-workflow/references/release-publish-mechanics.mdRefines release seam mapping guidance (including source-only publish mechanics).
.github/skills/operational-vs-release-workflow/references/branch-protection-and-promotion.mdUpdates ruleset/configure guidance and improves EOL-conflict resolution command examples.
.github/skills/merge-and-release/SKILL.mdNew skill documenting the end-to-end promotion merge and optional release dispatch procedure.
.github/skills/local-strict-review/SKILL.mdNew skill defining a pre-PR adversarial local review pass over the full diff.
.github/skills/git-commit-conventions/SKILL.mdClarifies destructive-command prohibition and documents a narrow post-squash cleanup exception.
.github/skills/drive-pr/SKILL.mdNew skill for driving PRs through review loops to develop and optionally to a promotion-ready state.
.github/skills/dotnet-codestyle/SKILL.mdStrengthens local hook guidance and clarifies CI/local enforcement expectations.
.github/skills/dotnet-codestyle/references/project-config.mdAdds explicit Nullable + XML documentation project configuration guidance.
.github/skills/dotnet-codestyle/references/conventions.mdExpands XML doc example to include a complete method body with validation/cancellation.
.github/skills/copilot-instructions-keeper/SKILL.mdUpdates intent-fidelity section coverage and clarifies ledger-preservation rules and references.
.github/skills/comment-and-doc-style/SKILL.mdAdds Docker lint authorization guidance; updates carried-doc references and PR-title/title-case examples.
.github/skills/comment-and-doc-style/references/line-endings.mdUpdates .gitattributes/default normalization guidance and clarifies mixed-consumer handling.
.github/skills/comment-and-doc-style/references/carried-doc-references.mdUpdates the carried-file scope list to match current carried set.
.github/skills/audit-a-repo/SKILL.mdUpdates live settings/rulesets/secrets verification guidance to use hub main tools.
.github/skills/agent-conduct/SKILL.mdAdds “pre-existing checkout is not ground truth” and “run local-strict-review before PR-bound claims” guidance.
Review details
  • Files reviewed: 27/27 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread.github/skills/comment-and-doc-style/SKILL.md
@ptr727ptr727 changed the title Re-vendor the .github/skills/ tree from the hubRe-vendor the .github/skills/ Tree from the HubAug 29, 2026
@ptr727
ptr727 requested a lite review from CopilotAugust 29, 2026 02:57

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several updated skill docs are now internally inconsistent with this repository’s current governance/config (notably repo-config/ scope and .gitattributes/line-ending policy), which would mislead contributors following the updated guidance.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

.github/skills/comment-and-doc-style/references/line-endings.md:67

  • This paragraph claims the “paired global LF defaults” remove the need for path-specific pins for extensionless executables, but this repo relies on explicit .gitattributes pins for extensionless scripts like .husky/pre-commit (and uses * -text by default). The guidance should reflect that POSIX-executed scripts still need git-level LF enforcement to avoid CRLF shebang breakage on checkout/renormalize.
Must be LF. A CRLF shebang (`#!/usr/bin/env bash\r`) breaks execution. The paired global LF
defaults cover extensionless executables, shell scripts, and directly executed Python without
path-specific pins. A CRLF-native operational repo adds narrow matching LF overrides in both
files only for scripts it executes on POSIX.
  • Files reviewed: 27/27 changed files
  • Comments generated: 4
  • Review effort level: Lite

Comment thread.github/skills/workflow-ci-contract/SKILL.md
Comment thread.github/skills/comment-and-doc-style/SKILL.md

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are documentation-only skill re-vendor updates (plus new skill docs) and review found no correctness, formatting, or consistency defects that would block merge.

Review details
  • Files reviewed: 27/27 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@ptr727
ptr727 merged commit 8080e58 into developAug 29, 2026
21 checks passed
@ptr727
ptr727 deleted the chore/hub-resync-skills-tree-2026-08 branch August 29, 2026 03:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727