Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Require a fresh Copilot pass before merging any PR - #694

Merged
ptr727 merged 7 commits into
developfrom
copilot-pass-rule
May 8, 2026
Merged

Require a fresh Copilot pass before merging any PR#694
ptr727 merged 7 commits into
developfrom
copilot-pass-rule

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Summary

Codifies the rule the user gave me after PR #693 was merged before Copilot had a chance to re-review my replies on the resolved threads. mergeStateStatus: CLEAN only confirms ruleset gates (thread resolution, status checks, signatures) — it does not confirm Copilot has actually re-evaluated the latest changes.

New rule: never merge a PR without a fresh "no issues found" review from copilot-pull-request-reviewer on the latest commit. If Copilot doesn't auto re-review within a reasonable window after the latest push (~5 min), ask before merging; silence is not approval.

Documented in:

  • AGENTS.md — new "Merging a PR" section with the verification recipe (gh api repos/<repo>/pulls/<n>/reviews + gh pr view <n> --json commits to confirm submitted_at > head commit's timestamp).
  • .github/copilot-instructions.md — one-line rule with link back to AGENTS.md.

This PR is itself an opportunity to dogfood the rule: it should not be merged until Copilot posts a fresh review on this commit and clears it.

Test plan

  • CI green
  • Copilot posts fresh review on this commit
  • No new inline threads (or threads addressed and re-reviewed)
  • Squash-merge into develop
  • Once on develop, promote to main as a normal develop → main PR

🤖 Generated with Claude Code

Document the rule that mergeStateStatus=CLEAN alone is not enough to
merge — Copilot must have re-reviewed the latest commit after any
thread resolutions or pushes. If Copilot does not auto re-review
within a reasonable window, ask before merging; silence is not
approval.
This was missing from the previous round of process documentation.
PR #693 was merged ~3 minutes after I (Claude) replied to Copilot's
threads, before Copilot had a chance to post a fresh review on the
new commit. The merge happened to be functionally correct but the
process was wrong, and it's the kind of small step that hides real
regressions in larger PRs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CopilotAI review requested due to automatic review settings May 7, 2026 23:15
Document the rule that, immediately after a develop->main merge lands
and main's publish workflows complete, the next action is a small
isolated PR bumping the minor in version.json on develop. Without it,
develop's next NBGV prerelease is numerically lower than the stable
that just shipped, producing visibly confusing version numbers in
HISTORY.md, --version output, and consumer update prompts.
Documentation only; the actual bump for the just-completed PR #693
promotion will land as a separate `bump-version-3.17` PR per the
"don't bundle the bump with other work" guidance in this same change.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Codifies an operational merge policy to ensure a pull request is not merged until copilot-pull-request-reviewer has re-reviewed the latest commit (so “CLEAN” mergeability/ruleset gates aren’t mistaken for “Copilot has re-evaluated the newest changes”).

Changes:

  • Added an “Merging a PR” section to AGENTS.md describing how to verify Copilot’s review is fresh relative to the PR head commit.
  • Added a one-line rule to .github/copilot-instructions.md pointing contributors back to AGENTS.md for the full procedure.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
AGENTS.mdAdds a new “Merging a PR” section documenting the required fresh Copilot review check and a CLI-based verification recipe.
.github/copilot-instructions.mdAdds a short rule reinforcing the fresh Copilot re-review requirement and links to the detailed procedure in AGENTS.md.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Address four issues Copilot raised on the previous commit:
- Clarify that review_on_push lives in the copilot_code_review
ruleset rule (verifiable via gh api), not in repo source files.
- Align the "no issues found" headline with the verification recipe
by stating up front that Copilot posts COMMENTED reviews here, so a
clean COMMENTED review with zero open threads IS the success state.
- Specify committedDate as the exact field to compare submitted_at
against, removing ambiguity between authoredDate and committedDate
in `gh pr view --json commits` output.
- Replace "ask the user" with "ask the maintainer" since this is a
repo-wide doc that survives author changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadAGENTS.md Outdated
Copilot pointed out (rightly) that comparing submitted_at against
committedDate is fragile: the reviews endpoint returns every author's
every review, and timestamp drift between client and server can flip
the comparison. The robust check is structural — does the latest
Copilot review's commit_id equal headRefOid?
Recipe rewritten to fetch headRefOid and the last Copilot review's
commit_id and compare strings. Also added a pointer to the GitHub UI
"Re-request review" flow for cases where Copilot doesn't auto re-review
on push (which happens occasionally; observed on this PR).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
- AGENTS.md headline said the freshness check was "review submitted
after committedDate" but step 2 specifies commit_id == headRefOid.
Aligned the headline to also use the SHA-equality wording so the
rule is internally consistent end-to-end.
- copilot-instructions.md: "develop's next prerelease numbers below
main's just-shipped stable" was missing a verb. Now reads "next
prerelease version numbers fall below..."
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
Comment thread.github/copilot-instructions.md Outdated
Round 5 Copilot findings:
- Use `copilot-pull-request-reviewer[bot]` (the bot login, with
"(shown as Copilot in the UI)" gloss) consistently in prose so it
matches the jq filter in the verification recipe — copy/paste from
the doc now produces a working command.
- The reviews endpoint is paginated by default in gh CLI; on PRs
with many review entries `last` could pick a stale Copilot review
from page 1. Use `--paginate` and a streaming `tail -1` filter so
the latest Copilot commit_id is reliably found regardless of
review-list length.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment threadAGENTS.md Outdated
Comment threadAGENTS.md Outdated
The Merging-a-PR section mixed `<repo>` and `<owner>/<repo>` in
adjacent gh api recipes; copy-pasting the bare `<repo>` form would
fail. Standardised on `<owner>/<repo>` to match the rest of the doc.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 661b945 into developMay 8, 2026
20 checks passed
@ptr727
ptr727 deleted the copilot-pass-rule branch May 8, 2026 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727