Conversation
## What The prose-gate composite action's `git rev-parse --verify` check on the diff base (`github.event.pull_request.base.sha`) now retries with backoff (0/2/4/8/15/30s, re-fetching the ref before each retry) instead of failing on the first miss. ## Why Fixes#1049. That issue documents `ptr727/Financial-Modeling#194`'s Lint sources job failing four times in a row (two reruns, one fresh push) with: ``` ::error::Diff base 'fcc57bfd9c...' does not resolve in this checkout. ::error::Check the ref name and that the job checks out with fetch-depth 0. ``` against a base SHA that was confirmed, both at failure time and afterward, to be `develop`'s genuine tip, a real ancestor of the PR branch, reachable by `git ls-remote`, and covered by the caller's own `fetch-depth: 0` unshallow fetch. The base was a merge commit created by a squash-merge only hours (in that case) to minutes before the failing runs, which points at GitHub-side replication lag on a freshly created merge commit rather than a logic bug in the checkout or the gate. Retrying the resolve check, rather than failing on the first miss, absorbs that lag without weakening the check itself: an actually-absent or malformed base still fails after exhausting the retries, in well under the job's overall timeout. ## Verification - `shellcheck -x` and manual review of the extracted composite-action script (the embedded script isn't covered by the repo's own `*.sh` gate, so this was a standalone check). - `python3 scripts/repo_gate.py` clean. - `python3 .github/actions/prose-gate/prose_lint.py --diff origin/develop -- .` clean against this change's own diff (dogfooding the gate this PR modifies). - Pre-commit hooks passed on commit. The GitHub-side replication-lag mechanism itself isn't independently reproducible from this session, so this is a mitigation for the symptom the issue describes rather than a proven root-cause fix; the retry is safe either way since it only widens the window before the existing failure mode fires. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved reliability when determining the comparison baseline. * Added retry and refresh handling to reduce failures caused by temporarily unavailable branch data. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
PR Summary by QodoRetry Prose Gate Base Resolution During GitHub Replication Lag
AI Description
Diagram
High-Level Assessment
Files changed (1) |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe prose-gate action now retries diff base resolution with increasing delays. It fetches the base ref from ChangesProse-gate diff base resolution
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:⚪ Minimal · up to This PR promotes the reviewed develop branch to main with no actionable merge-blocking risk remaining beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Review by Qodo🐞 Bugs (0)📘 Rule violations (0)📎 Requirement gaps (0)Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper |
Uh oh!
There was an error while loading. Please reload this page.
Promotes develop to main.
Included
Summary by CodeRabbit