Skip to content

Fix Mid-Sentence Line Wraps Copilot Caught on the Promotion PR - #1084

Merged
ptr727 merged 2 commits into
developfrom
feature/1081-wrap-fix
Aug 29, 2026
Merged

Fix Mid-Sentence Line Wraps Copilot Caught on the Promotion PR#1084
ptr727 merged 2 commits into
developfrom
feature/1081-wrap-fix

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Fix-up to #1081, found by the develop -> main promotion PR (#1077)'s fresh full-diff review.

CLAUDE.md's intro paragraph and resync-a-repo/SKILL.md's step 1 both had a sentence hard-wrapped across physical lines mid-sentence, against this repo's prose convention (paragraphs and sentences stay on one unwrapped physical line, per .markdownlint-cli2.jsonc disabling MD013 for exactly this). Pure re-flow, no wording changed (verified: git diff -w --word-diff shows zero word-level differences).

Ran local-strict-review before pushing: confirmed no wording changed, both new sentence/line joins read correctly, mirrors byte-identical. One informational note surfaced (not fixed here, correctly out of scope): the same wrap pattern is pervasive fleet-wide and deliberately unenforced (the sentence-split prose_lint rule is opt-in, same rationale as sentence-length) - not a regression this branch introduced.

CLAUDE.md's intro paragraph and resync-a-repo/SKILL.md's step 1 both
had a sentence hard-wrapped across physical lines instead of kept
unwrapped or split at a sentence boundary, against this repo's
established prose convention. Pure re-flow, no wording changed.
CopilotAI lite review requested due to automatic review settings August 29, 2026 04:28
@coderabbitai

coderabbitaiBot commented Aug 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 13 minutes.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c93cc4c8-ddc4-4e9e-b990-b6a6022fe337

📥 Commits

Reviewing files that changed from the base of the PR and between 5fcd378 and 1cd40b5.

📒 Files selected for processing (5)
  • .agents/skills/resync-a-repo/SKILL.md
  • .claude-plugin/fleet-skills/.source-digest
  • .claude-plugin/fleet-skills/skills/resync-a-repo/SKILL.md
  • .github/skills/resync-a-repo/SKILL.md
  • CLAUDE.md

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Normalize Markdown sentence line wrapping

📝 Documentation🕐 Less than 10 minutes

Grey Divider

AI Description

• Reflows two Markdown passages without changing their wording.
• Keeps resync skill mirrors synchronized and refreshes the plugin source digest.
Diagram

graph TD
Convention["Prose convention"] --> Source["Source skill"] --> Plugin["Plugin mirror"] --> Digest["Source digest"]
Source --> GitHub["GitHub mirror"]
Convention --> Claude["Claude entry"]
Loading
High-Level Assessment

The focused reflow is the optimal approach because it corrects the formatting convention without altering meaning. Applying the canonical skill change to both mirrors and refreshing the existing digest preserves distribution integrity without introducing unnecessary lint-policy changes.

Files changed (5) +23 / -22

Documentation (4) +22 / -21
SKILL.mdReflow resync step-one sentences+7/-6

Reflow resync step-one sentences

• Moves the step-one prose break to a sentence boundary while preserving every word and the existing guidance.

.agents/skills/resync-a-repo/SKILL.md

SKILL.mdSynchronize plugin resync skill reflow+7/-6

Synchronize plugin resync skill reflow

• Applies the canonical sentence-boundary reflow to the Claude plugin skill mirror without changing wording.

.claude-plugin/fleet-skills/skills/resync-a-repo/SKILL.md

SKILL.mdSynchronize GitHub resync skill reflow+7/-6

Synchronize GitHub resync skill reflow

• Applies the canonical sentence-boundary reflow to the GitHub skill mirror without changing wording.

.github/skills/resync-a-repo/SKILL.md

CLAUDE.mdUnwrap the introductory paragraph+1/-3

Unwrap the introductory paragraph

• Joins the introduction onto one physical line to match the repository's prose convention, with no wording changes.

CLAUDE.md

Other (1) +1 / -1
.source-digestRefresh plugin source digest+1/-1

Refresh plugin source digest

• Updates the fleet-skills digest to reflect the reflowed mirrored skill content.

.claude-plugin/fleet-skills/.source-digest

@qodo-code-review

qodo-code-reviewBot commented Aug 29, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0)📘 Rule violations (0)📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Wrapped resync prose sentences✓ Resolved📜 Skill insight✧ Quality
Description
The reflowed SKILL.md paragraphs still split sentences across physical lines, including the
sentence beginning This is not advisory language and the following sentences. This violates the
requirement that multi-line prose use exactly one sentence per line and never wrap mid-sentence.
Code

.agents/skills/resync-a-repo/SKILL.md[R62-65]

+ This is not advisory language to weigh against how routine the diff looks, a diff that looks+ routine is exactly the shape the AGENTS.md-overwrite incident took. Do not proceed to the+ re-vendor until the probe has run and any local addition it finds has a destination, per that+ skill's own procedure. `CLAUDE.md` is outside that guard's scope: it carries no mixed or
Relevance

●●● Strong

Recent accepted reviews enforce one-sentence-per-line prose; this finding directly matches the PR's
stated purpose.

PR-#978
PR-#448

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The added lines visibly continue prose sentences across physical line boundaries instead of ending
each line at a sentence boundary. This matches the checklist's failure condition for wrapped
multi-line prose.

.agents/skills/resync-a-repo/SKILL.md[62-67]
Skill: comment-and-doc-style

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
The changed Markdown prose wraps individual sentences across physical lines.
## Issue Context
Compliance rule 2826725 requires one sentence per line and prohibits mid-sentence line wraps. The same reflow appears in the mirrored skill files, which should remain byte-identical.
## Fix Focus Areas
- .agents/skills/resync-a-repo/SKILL.md[62-67]
- .claude-plugin/fleet-skills/skills/resync-a-repo/SKILL.md[62-67]
- .github/skills/resync-a-repo/SKILL.md[62-67]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 72 rules
✅ Skills: 5 invoked
comment-and-doc-style
dotnet-codestyle
python-codestyle
shell-codestyle
workflow-ci-contract
Review mode: 🚀 Fast: This is a localized documentation-only reflow across mirrored skill files plus a digest update, with no intended behavioral or wording change.

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread.agents/skills/resync-a-repo/SKILL.md Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated resync-a-repo skill paragraph remains hard-wrapped across multiple physical lines, conflicting with the repo’s “one logical paragraph per line” Markdown prose convention.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR is a documentation-only reflow fix intended to remove mid-sentence hard wraps that were flagged in the promotion PR’s full-diff review, without changing wording.

Changes:

  • Reflow CLAUDE.md’s introductory paragraph onto a single physical line.
  • Reflow the resync-a-repo skill’s “Apply, in this order” step 1 paragraph(s) in each distributed copy.
  • Update the fleet-skills .source-digest to reflect the content change.
File summaries
FileDescription
CLAUDE.mdCollapses the intro paragraph to a single physical line.
.github/skills/resync-a-repo/SKILL.mdReflows step-1 prose for the GitHub skill distribution copy.
.agents/skills/resync-a-repo/SKILL.mdReflows step-1 prose for the source skill copy.
.claude-plugin/fleet-skills/skills/resync-a-repo/SKILL.mdReflows step-1 prose for the Claude plugin distribution copy.
.claude-plugin/fleet-skills/.source-digestUpdates the digest to match the distribution content.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread.github/skills/resync-a-repo/SKILL.md Outdated
Comment thread.claude-plugin/fleet-skills/skills/resync-a-repo/SKILL.md Outdated
Comment thread.agents/skills/resync-a-repo/SKILL.md Outdated
…llow-up
The prior fix split the bold clause from its continuation but the
continuation itself was still hard-wrapped mid-sentence across
several lines, matching this repo's genuine sentence-per-line rule
only in the loosest sense. Joined the whole numbered item into one
physical line, matching CLAUDE.md's already-passing fix and this
file's own line 45-style precedent. Pure reflow, verified with
git diff -w --word-diff: zero word-level changes.
CopilotAI review requested due to automatic review settings August 29, 2026 04:35

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are pure prose reflow across the relevant distributions and are internally consistent, with no functional or behavioral impact.

Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@ptr727

Copy link
Copy Markdown
OwnerAuthor

Qodo finding "Wrapped resync prose sentences": fixed in 1cd40b5, collapsed the whole numbered item into one unwrapped physical line. Already replied+resolved on the corresponding review thread; this comment answers Qodo's own summary listing directly per its own guidance.

@ptr727
ptr727 merged commit b283bb6 into developAug 29, 2026
9 checks passed
@qodo-code-review

Copy link
Copy Markdown

Qodo finding "Wrapped resync prose sentences": fixed in 1cd40b5, collapsed the whole numbered item into one unwrapped physical line. Already replied+resolved on the corresponding review thread; this comment answers Qodo's own summary listing directly per its own guidance.

Acknowledged. finding 1 is addressed by commit 1cd40b5, which collapses the numbered item into one unwrapped physical line. I’m taking no further action because you’ve already resolved it on the corresponding review thread.

@ptr727
ptr727 deleted the feature/1081-wrap-fix branch August 29, 2026 04:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727