Skip to content

Join the Unresolved-Rule Placeholder Onto One Physical Line - #1085

Merged
ptr727 merged 1 commit into
developfrom
feature/placeholder-line-wrap
Aug 29, 2026
Merged

Join the Unresolved-Rule Placeholder Onto One Physical Line#1085
ptr727 merged 1 commit into
developfrom
feature/placeholder-line-wrap

Conversation

@ptr727

Copy link
Copy Markdown
Owner

Found by a suppressed Qodo finding (low-confidence, 3x across the mirrored copies) on the develop -> main promotion PR (#1077): local-strict-review/SKILL.md's bracket placeholder was split across two physical lines inside the fenced template, which the finding said hurts copy-paste usability and deviates from AGENTS.md's own single-line closing-sentence shape.

Joined onto one physical line, no wording changed (verified: git diff -w --word-diff shows zero word-level differences).

Ran local-strict-review before pushing: join point reads cleanly, mirrors byte-identical. One stylistic-only observation surfaced and not acted on: the joined line (123 chars) is now wider than the fence's other five fields, which wrap at ~90-94 chars with a hanging indent to simulate a realistic terminal width. Not a rule violation (no gate checks fence-internal line width) and directly trades off against the reviewer's own explicit one-line request, so left as one line.

Qodo flagged (suppressed, low-confidence but genuine) that the
bracket placeholder was split across two physical lines inside the
fenced template, hurting copy-paste usability. Joined into one line,
matching AGENTS.md's own single-line closing sentence shape. Pure
reflow, verified with git diff -w --word-diff: zero word-level
changes.
CopilotAI lite review requested due to automatic review settings August 29, 2026 04:48
@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e6d692d9-9cc8-46a5-961c-b182c05a860f

📥 Commits

Reviewing files that changed from the base of the PR and between b283bb6 and 1e61db2.

📒 Files selected for processing (4)
  • .agents/skills/local-strict-review/SKILL.md
  • .claude-plugin/fleet-skills/.source-digest
  • .claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md
  • .github/skills/local-strict-review/SKILL.md

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0)📘 Rule violations (0)📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Keep the Unresolved-Rule Placeholder on One Line

📝 Documentation⚙️ Configuration changes🕐 Less than 5 minutes

Grey Divider

AI Description

• Joins the unresolved-rule placeholder for reliable copy-paste and consistent sentence formatting.
• Preserves identical wording across source, Claude, and GitHub skill distributions.
Diagram

graph TD
SRC["Source skill"] --> BUILD["Distribution build"] --> CLAUDE["Claude skill"]
BUILD --> GITHUB["GitHub skill"]
BUILD --> DIGEST["Source digest"]
Loading
High-Level Assessment

The current approach is optimal: reflow the canonical skill, regenerate both required mirrors, and refresh the digest. Leaving generated copies untouched would create distribution drift, while changing wording is unnecessary for this copy-paste issue.

Files changed (4) +4 / -7

Documentation (3) +3 / -6
SKILL.mdKeep unresolved-rule placeholder on one physical line+1/-2

Keep unresolved-rule placeholder on one physical line

• Joins the bracketed unresolved-rule placeholder without changing its wording. This improves direct copying and matches the referenced closing sentence's single-line shape.

.agents/skills/local-strict-review/SKILL.md

SKILL.mdMirror the one-line placeholder in the Claude skill+1/-2

Mirror the one-line placeholder in the Claude skill

• Carries the word-preserving placeholder reflow into the generated Claude plugin copy.

.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md

SKILL.mdMirror the one-line placeholder in the GitHub skill+1/-2

Mirror the one-line placeholder in the GitHub skill

• Carries the word-preserving placeholder reflow into the generated GitHub skill copy.

.github/skills/local-strict-review/SKILL.md

Other (1) +1 / -1
.source-digestRefresh generated skill source digest+1/-1

Refresh generated skill source digest

• Updates the fleet-skills digest to reflect the revised canonical skill bytes and regenerated distribution.

.claude-plugin/fleet-skills/.source-digest

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward documentation/template formatting adjustment applied consistently across all mirrored copies with the digest updated accordingly.

Pull request overview

Aligns the local-strict-review skill's subagent-briefing template with the intended copy-paste shape by joining the unresolved-rule placeholder onto a single physical line, keeping all mirrored distributions in sync.

Changes:

  • Joined the unresolved-rule placeholder in the fenced briefing template onto one line (no wording change).
  • Applied the same update across the distributed/mirrored skill copies.
  • Updated the fleet-skills source digest to reflect the new distribution content.
File summaries
FileDescription
.github/skills/local-strict-review/SKILL.mdJoins the unresolved-rule placeholder to one physical line in the template.
.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.mdMirrors the same one-line placeholder change in the plugin distribution.
.claude-plugin/fleet-skills/.source-digestUpdates the digest to match the regenerated distribution content.
.agents/skills/local-strict-review/SKILL.mdApplies the one-line placeholder change in the skill source-of-truth.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ptr727ptr727 mentioned this pull request Aug 29, 2026
@ptr727
ptr727 merged commit ff93269 into developAug 29, 2026
9 checks passed
@ptr727
ptr727 deleted the feature/placeholder-line-wrap branch August 29, 2026 04:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ptr727