Conversation
…#184) Surfaced while re-syncing the PlexCleaner downstream onto the template. - `publish-release.yml`: fail fast when a publish is dispatched on a non-default ref; the matrix builds both branches, so a non-default dispatch mis-versions the main leg and publishes a malformed non-prerelease "Latest". - `build-release-task.yml`: refuse to create a main release whose `SemVer2` carries a prerelease suffix (root-cause-agnostic safety net). - `.editorconfig`: correct JSON/JSONC casing in the section comment. - `build-pypilibrary-task.yml`: note the transient post-promotion exception in the PEP 440 ordering comment. Fixes#183Fixes#182Fixes#181
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds guardrails to prevent malformed public releases when publish-release.yml is manually dispatched from a non-default ref, and adds a defense-in-depth check to ensure main releases never publish a prerelease-form SemVer2. It also includes small comment/casing fixes discovered during downstream re-syncs.
Changes:
- Add a fail-fast check in
publish-release.ymlto rejectworkflow_dispatchruns launched from a non-default ref (the publish matrix always builds both branches). - Add a safety-net step in
build-release-task.ymlto refuse publishing amainGitHub release ifSemVer2contains a prerelease suffix (-...). - Fix minor comment/casing issues (
.editorconfigJSON/JSONC casing; clarify PEP 440 ordering comment in PyPI build task).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/publish-release.yml | Fails fast on manual dispatch from a non-default ref to prevent mis-versioned main leg releases. |
.github/workflows/build-release-task.yml | Adds a main-only SemVer2 sanity check to prevent publishing malformed non-prerelease “Latest” releases. |
.github/workflows/build-pypilibrary-task.yml | Clarifies the PEP 440 ordering comment to note the transient post-promotion exception. |
.editorconfig | Updates the JSON/JSONC section comment casing to match documented tooling-name casing. |
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the downstream-re-sync fixes from develop to main.
publish-release.yml: fail fast when a publish is dispatched on a non-default ref; a schedule/dispatch builds both branches in the matrix regardless of the triggering ref, so a non-default dispatch mis-versions the main leg and publishes a malformed non-prerelease "Latest".build-release-task.yml: refuse to create a main release whoseSemVer2carries any prerelease identifier (root-cause-agnostic safety net)..editorconfig: correct JSON/JSONC casing in the section comment.build-pypilibrary-task.yml: note the transient post-promotion exception in the PEP 440 ordering comment.Fixes#183
Fixes#182
Fixes#181