Conversation
…#201) The cleanup-artifacts step is best-effort, but set -euo pipefail + the per-command guards only cover expected list/delete failures; an unexpected failure (e.g. gh itself) would still red the run. Add continue-on-error: true to the delete step in publish-release.yml and test-pull-request.yml, and note it in the AGENTS.md recipe. Surfaced by Copilot on the NxWitness re-sync (ptr727/NxWitness#443).
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the current develop head to main as a standard release promotion, carrying forward the workflow-only housekeeping hardening from #201 to ensure artifact cleanup cannot cause a workflow run to fail.
Changes:
- Document in
AGENTS.mdthat artifact-cleanup deletion steps should setcontinue-on-error: trueto guarantee best-effort behavior. - Add
continue-on-error: trueto the artifact deletion step in the terminal cleanup job intest-pull-request.yml. - Add
continue-on-error: trueto the artifact deletion step in the terminal cleanup job inpublish-release.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AGENTS.md | Updates the workflow conventions to explicitly require continue-on-error: true on artifact cleanup deletion steps. |
| .github/workflows/test-pull-request.yml | Makes the artifact deletion step best-effort at the workflow level by setting continue-on-error: true. |
| .github/workflows/publish-release.yml | Makes the artifact deletion step best-effort at the workflow level by setting continue-on-error: true. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the current
develophead tomain.Contents:
continue-on-error: trueon thecleanup-artifactsdelete step inpublish-release.ymlandtest-pull-request.ymlso best-effort housekeeping can never red the run (from NxWitness#443 Copilot review).Standard release promotion: merge (not squash). Publishing remains deferred until the artifact-storage quota recalculates.
🤖 Generated with Claude Code