Adopt the job-suffix naming for the PR-gate aggregator - #237
Merged
Conversation
Rename the ruleset-bound aggregator to "Check pull request workflow status job", matching the fleet's <name> job convention and removing the old un-suffixed exception. The job name and the ruleset context are one string renamed together: updates test-pull-request.yml, repo-config/{develop,main}.json, and the exception rules + references in AGENTS.md / WORKFLOW.md / README.md / repo-config/README.md. Requires the live develop+main rulesets to move to the new context in lockstep (done at merge).
Correct the Utilities and PlexCleaner audit reports: the ...job naming is the fleet canonical, not a drift (those reports predated this adoption).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the template repository with the fleet-standard convention that all job name: values end in job, including the ruleset-bound PR-gate aggregator, and updates the corresponding required-status-check context everywhere it is referenced.
Changes:
- Rename the PR-gate aggregator job
name:toCheck pull request workflow status jobin.github/workflows/test-pull-request.yml. - Update both committed ruleset JSONs (
repo-config/develop.json,repo-config/main.json) to require the new status-check context string. - Propagate the new canonical check name and the “rename job + ruleset context together” rule across governance docs and the affected audit reports.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WORKFLOW.md | Updates the job/step naming rule and the workflow diagram to use Check pull request workflow status job. |
| reports/utilities/audit.md | Reclassifies the ... job required-check naming as canonical (not drift) and updates the narrative accordingly. |
| reports/plexcleaner/audit.md | Same as Utilities: corrects the report to treat the ... job naming as canonical. |
| repo-config/README.md | Updates the documented required check name to Check pull request workflow status job. |
| repo-config/main.json | Renames the required status check context to Check pull request workflow status job. |
| repo-config/develop.json | Renames the required status check context to Check pull request workflow status job. |
| README.md | Updates the public-facing description of the ruleset-bound aggregator check name. |
| AGENTS.md | Replaces the old “do not rename” exception with the new “rename job name + ruleset context together” rule and updates references. |
| .github/workflows/test-pull-request.yml | Renames the aggregator job name: and updates the adjacent comment to reflect the new rename-in-lockstep rule. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the fleet-standard
<name> jobnaming for the ruleset-bound PR-gate aggregator, removing the old un-suffixed exception. All five audited downstream repos already useCheck pull request workflow status job; the template was the lone holdout (the audits confirmed this).test-pull-request.yml+ bothrepo-config/{develop,main}.jsoncontexts.AGENTS.md/WORKFLOW.md(D1.5, D9.2, name-suffix rule) with the new rule: a ruleset-bound job.sname:and its rulesetcontext:are one string, renamed together (job +repo-config+ live ruleset in lockstep) or enforcement breaks. Update the check-name references inREADME.md/repo-config/README.md/ the WORKFLOW diagram....jobnaming is canonical, not a drift (they predated this adoption).Coordination: the live
develop+mainrulesets are moved to the new contextCheck pull request workflow status jobin lockstep at merge time (this PR is intentionally blocked on the old required check until then). Maintainer-supervised.🤖 Generated with Claude Code