Model-aware regen output path; full dispatch expression in D4 - #319
Merged
Conversation
…#315) - repo-config/README.md: the regen snippet writes the develop payload to operational/develop.json when the carry has no develop.json (operational repos), instead of always develop.json. - WORKFLOW.md D4: spell the dispatch leg as github.event_name == 'workflow_dispatch', matching the canonical workflows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies forward fixes from round-2 Copilot findings after #315: it clarifies the exact workflow-dispatch gate expression in the workflow audit checklist, and makes the repo-config ruleset regen snippet model-aware for operational carries.
Changes:
- Update WORKFLOW.md D4 to spell the dispatch leg explicitly as
github.event_name == 'workflow_dispatch'. - Adjust the
repo-config/README.mdregen snippet to write thedevelopruleset payload torepo-config/operational/develop.jsonwhenrepo-config/develop.jsonis absent (operational carry layout).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WORKFLOW.md | Clarifies the expected dispatch-gate expression in D4 to avoid ambiguous/incorrect shorthand. |
| repo-config/README.md | Makes the ruleset regen output path for develop resilient to operational-carry layouts. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 Copilot findings from the #315 promotion, fixed forward: the ruleset-regen snippet routes the develop payload to
operational/develop.jsonon an operational carry (nodevelop.jsonpresent), and WORKFLOW.md D4 spells the dispatch leg asgithub.event_name == 'workflow_dispatch'.🤖 Generated with Claude Code